Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Replace hotgraphic view with narrative view on parent #270

Merged
merged 2 commits into from
May 18, 2023
Merged

Fix: Replace hotgraphic view with narrative view on parent #270

merged 2 commits into from
May 18, 2023

Conversation

oliverfoster
Copy link
Member

fixes #267

Fix

  • Replace hotgraphic view with narrative view on parent, allowing for clearup on page destruction

@oliverfoster oliverfoster self-assigned this May 10, 2023
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

guywillis
guywillis approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested on chrome, working as expected.

@joe-allen-89 joe-allen-89 merged commit 18a5119 into master May 18, 2023
@joe-allen-89 joe-allen-89 deleted the issue/267 branch May 18, 2023 15:06
github-actions bot pushed a commit that referenced this pull request May 18, 2023
@semantic-release-bot
Chore(release): 6.7.4 [skip ci]
a5b340d 
## [6.7.4](v6.7.3...v6.7.4) (2023-05-18)

### Fix

* Replace hotgraphic view with narrative view on parent (#270) ([18a5119](18a5119)), closes [#270](#270)
@github-actions
Copy link

🎉 This PR is included in version 6.7.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StuartNicholls StuartNicholls StuartNicholls approved these changes

@guywillis guywillis guywillis approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not updated parents childViews when switching for narrative.
5 participants
@oliverfoster @StuartNicholls @guywillis @cahirodoherty-learningpool @joe-allen-89