Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component schema broken for AT #51

Open
cahirodoherty-learningpool opened this issue Jan 24, 2023 · 4 comments · May be fixed by #52
Open

Component schema broken for AT #51

cahirodoherty-learningpool opened this issue Jan 24, 2023 · 4 comments · May be fixed by #52
Assignees
Labels

Comments

@cahirodoherty-learningpool
Copy link
Contributor

Subject of the issue/enhancement/features

Schema type is missing for isOptional override

Your environment

  • FW5.24.4
  • AT v0.11.1

Steps to reproduce

Create a course and add a Blank component
Edit component

Expected behaviour

Page loads as expected with component config options

Actual behaviour

JS error causing page load to fail (due to missing schema.type

@paulstevendev
Copy link

paulstevendev commented Jan 24, 2023

When testing this in the AT I see 2 "Is this optional" settings

image

image

@simondate
Copy link
Member

I can confirm that I get the same issue with AAT 0.11.1

@cahirodoherty-learningpool
Copy link
Contributor Author

@taylortom Linked PR is with you so attaching the issue for now too. Happy for this to come back to me after you've had a chance to investigate if the issue isn't automatically resolved

@dymitar
Copy link

dymitar commented Aug 4, 2023

If you remove
"_isOptional": { "type": "boolean", "required": false, "default": true }
from properties.schema the component editing opens without issues (Authoring 0.11.1, Framework 5.31.20)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

5 participants