Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Bank blocks only, restore other children (fixes #192) #193

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Fix: Bank blocks only, restore other children (fixes #192) #193

merged 2 commits into from
Mar 5, 2024

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 27, 2024 •
edited
Loading

fixes #192

Fix

  • Reattached any non-block children, such as trickle buttons, if they are removed in randomisation or banking
  • Changed bad variable _quizBankId to correct _quizBankID

@oliverfoster oliverfoster self-assigned this Feb 27, 2024
marissa-champions
marissa-champions approved these changes Feb 27, 2024
View reviewed changes
Copy link

@marissa-champions marissa-champions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

marissa-champions

This comment was marked as duplicate.

Sign in to view

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit d85f4f7 into master Mar 5, 2024
@oliverfoster oliverfoster deleted the issue/192 branch March 5, 2024 11:12
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
@semantic-release-bot
Chore(release): 5.1.11 [skip ci]
eb44d70 
## [5.1.11](v5.1.10...v5.1.11) (2024-03-05)

### Fix

* Bank blocks only, restore other children (fixes #192) (#193) ([d85f4f7](d85f4f7)), closes [#192](#192) [#193](#193)
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

🎉 This PR is included in version 5.1.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@marissa-champions marissa-champions marissa-champions approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assessment Banks with Trickle Not Unlocking Next Article
4 participants
@oliverfoster @cahirodoherty-learningpool @marissa-champions @joe-allen-89