Fixes and Tests for PolarsMixin #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 53-tests-for-polarsmixin
… 53-tests-for-polarsmixin
… 53-tests-for-polarsmixin
… 53-tests-for-polarsmixin
Closed
Codecov ReportAttention: Patch coverage is
|
… 53-tests-for-polarsmixin
adamamer20
added
the
enhancement
for more information, see https://pre-commit.ci
…r20/mesa-frames into 53-tests-for-polarsmixin
rht
approved these changes
Aug 13, 2024
|
Did you use polars-upgrade for any of the changes in this PR? |
No, just something for the future. It's pretty new, so I have to assess stability. |
|
I'm not familiar with Polars API at the moment, so I approve the PR so as not to block you. |
No problem, we can always evaluate performance later. I'll just add tests for missing lines. |
…r20/mesa-frames into 53-tests-for-polarsmixin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the logic of many
PolarsMixinmethods and adds tests for all methods.