Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump to use node20 runtime, actions/checkout to v4 #727

Closed
wants to merge 3 commits into from

Conversation

kbdharun
Copy link

@kbdharun kbdharun commented Sep 5, 2023

Description:

Node20 was added to Actions Runner on v2.308.0 and Node16 reaches end of life soon on 11 Sep 2023.

Therefore, This PR updates the default runtime to node20. I have bumped the actions/checkout version to v4 for the same.

Related issue:

actions/runner#2732

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

A major version bump might be needed after the PRs merge.
I referred to actions/setup-go#421 for this PR.

@kbdharun kbdharun requested a review from a team as a code owner September 5, 2023 03:28
@kbdharun kbdharun changed the title feat: bump to use node20 runtime feat: bump to use node20 runtime, actions/checkout to v4 Sep 5, 2023
@dmitry-shibanov
Copy link
Contributor

Hello @kbdharun. Thank you for your pull request. Could you please revert changes in docs/adrs/0000-caching-dependencies.md

@chenrui333
Copy link
Contributor

what is blocking the PR merge?

@akx
Copy link
Contributor

akx commented Dec 12, 2023

This was superseded by #772.

@kbdharun
Copy link
Author

This was superseded by #772.

Thanks for the information 😄 , glad it got merged.

@kbdharun kbdharun closed this Dec 12, 2023
@kbdharun kbdharun deleted the patch-1 branch December 12, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants