Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node20 to runner #2732

Merged
merged 27 commits into from
Aug 11, 2023
Merged

Add node20 to runner #2732

merged 27 commits into from
Aug 11, 2023

Conversation

takost
Copy link
Contributor

@takost takost commented Aug 3, 2023

Base automatically changed from takost/remove-node12 to main August 10, 2023 13:16
xiehan added a commit to xiehan/projen-github-action-typescript that referenced this pull request Sep 5, 2023
Node 20 is now supported by the runner (actions/runner#2732) so we should make sure this library supports it as well.
mergify bot pushed a commit to projen/projen-github-action-typescript that referenced this pull request Oct 31, 2023
Node 20 is now supported by the runner (actions/runner#2732) so we should make sure this library supports it as well.
Copy link

@D5688 D5688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdb

  • [ ]

@@ -158,23 +163,29 @@ fi
# Download the external tools only for OSX.
if [[ "$PACKAGERUNTIME" == "osx-x64" ]]; then
acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-darwin-x64.tar.gz" node16 fix_nested_dir
acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/node-v${NODE20_VERSION}-darwin-x64.tar.gz" node20 fix_nested_dir

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mio

fi

if [[ "$PACKAGERUNTIME" == "osx-arm64" ]]; then
# node.js v12 doesn't support macOS on arm64.
acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-darwin-arm64.tar.gz" node16 fix_nested_dir
acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/node-v${NODE20_VERSION}-darwin-arm64.tar.gz" node20 fix_nested_dir

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pa

@@ -158,23 +163,29 @@ fi
# Download the external tools only for OSX.
if [[ "$PACKAGERUNTIME" == "osx-x64" ]]; then
acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-darwin-x64.tar.gz" node16 fix_nested_dir
acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/node-v${NODE20_VERSION}-darwin-x64.tar.gz" node20 fix_nested_dir

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vgf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants