Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: be explicit about sync/async behaviour #45

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

achingbrain
Copy link
Owner

Crossing async boundaries is not free so allow the Duplex type to specify whether it is sync or async.

BREAKING CHANGE: the TSource and TSink generic arguments to the Duplex type now refer to the stream type and not the type of objects yielded by the stream

Crossing async boundaries is not free so allow the `Duplex` type to
specify whether it is sync or async.

BREAKING CHANGE: the `TSource` and `TSink` generic arguments to the `Duplex` type now refer to the stream type and not the type of objects yielded by the stream
@achingbrain achingbrain merged commit 374296f into master Apr 4, 2023
@achingbrain achingbrain deleted the fix/be-explicit-about-async branch April 4, 2023 09:57
github-actions bot pushed a commit that referenced this pull request Apr 4, 2023
## [2.0.0](v1.0.5...v2.0.0) (2023-04-04)

### ⚠ BREAKING CHANGES

* the `TSource` and `TSink` generic arguments to the `Duplex` type now refer to the stream type and not the type of objects yielded by the stream

### Bug Fixes

* be explicit about sync/async behaviour ([#45](#45)) ([374296f](374296f))
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

achingbrain added a commit to ChainSafe/js-libp2p-yamux that referenced this pull request Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain added a commit to libp2p/js-libp2p-tcp that referenced this pull request Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just
`AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain added a commit to alanshaw/it-ws that referenced this pull request Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just
`AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain added a commit to libp2p/js-libp2p-webtransport that referenced this pull request Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just
`AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain added a commit to alanshaw/it-ws that referenced this pull request Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just
`AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain added a commit to libp2p/js-libp2p-websockets that referenced this pull request Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are
`AsyncGenerator`s and not just `AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain added a commit to libp2p/js-libp2p-websockets that referenced this pull request Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are
`AsyncGenerator`s and not just `AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain added a commit to libp2p/js-libp2p-daemon that referenced this pull request Apr 19, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just
`AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain added a commit to libp2p/js-libp2p-daemon that referenced this pull request Apr 19, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just
`AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
wemeetagain pushed a commit to ChainSafe/js-libp2p-yamux that referenced this pull request Apr 19, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain added a commit to achingbrain/js-libp2p-noise that referenced this pull request Apr 19, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are
`AsyncGenerator`s and not just `AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain added a commit to achingbrain/gossipsub-js that referenced this pull request Apr 19, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not
just `AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
wemeetagain pushed a commit to ChainSafe/js-libp2p-gossipsub that referenced this pull request Apr 20, 2023
deps!: update stream types

libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not
just `AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain added a commit to libp2p/js-libp2p-webtransport that referenced this pull request Apr 28, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed
mpetrunic added a commit to ChainSafe/js-libp2p-noise that referenced this pull request May 5, 2023
* deps!: update stream types

libp2p streams are now explicit about the types of sync/sources they provide, showing that they are
`AsyncGenerator`s and not just `AsyncIterable`s.

Refs: achingbrain/it-stream-types#45

BREAKING CHANGE: the type of the source/sink properties have changed

* fix: interop

Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>

---------

Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
Co-authored-by: Marin Petrunic <marin.petrunic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant