From 5c01a9a4514c4e6a52c087a6663469bd6a2ca0e2 Mon Sep 17 00:00:00 2001 From: kobayu858 <129580202+kobayu858@users.noreply.github.com> Date: Fri, 26 Jul 2024 17:07:04 +0900 Subject: [PATCH] fix(autoware_behavior_path_planner_common): fix passedByValue (#8209) * fix:clang format Signed-off-by: kobayu858 * fix:passedByValue Signed-off-by: kobayu858 * fix:passedByValue Signed-off-by: kobayu858 --------- Signed-off-by: kobayu858 --- .../behavior_path_planner_common/marker_utils/utils.hpp | 2 +- .../behavior_path_planner_common/utils/path_utils.hpp | 6 +++--- .../src/marker_utils/utils.cpp | 2 +- .../src/utils/path_utils.cpp | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/planning/behavior_path_planner/autoware_behavior_path_planner_common/include/autoware/behavior_path_planner_common/marker_utils/utils.hpp b/planning/behavior_path_planner/autoware_behavior_path_planner_common/include/autoware/behavior_path_planner_common/marker_utils/utils.hpp index 819800281fcc5..85c2563c5d98c 100644 --- a/planning/behavior_path_planner/autoware_behavior_path_planner_common/include/autoware/behavior_path_planner_common/marker_utils/utils.hpp +++ b/planning/behavior_path_planner/autoware_behavior_path_planner_common/include/autoware/behavior_path_planner_common/marker_utils/utils.hpp @@ -67,7 +67,7 @@ MarkerArray createFootprintMarkerArray( const std::string && ns, const int32_t & id, const float & r, const float & g, const float & b); MarkerArray createPointsMarkerArray( - const std::vector points, const std::string & ns, const int32_t id, const float r, + const std::vector & points, const std::string & ns, const int32_t id, const float r, const float g, const float b); MarkerArray createPoseMarkerArray( diff --git a/planning/behavior_path_planner/autoware_behavior_path_planner_common/include/autoware/behavior_path_planner_common/utils/path_utils.hpp b/planning/behavior_path_planner/autoware_behavior_path_planner_common/include/autoware/behavior_path_planner_common/utils/path_utils.hpp index 3b06c7e03cae1..45bdb296f6575 100644 --- a/planning/behavior_path_planner/autoware_behavior_path_planner_common/include/autoware/behavior_path_planner_common/utils/path_utils.hpp +++ b/planning/behavior_path_planner/autoware_behavior_path_planner_common/include/autoware/behavior_path_planner_common/utils/path_utils.hpp @@ -79,7 +79,7 @@ PathWithLaneId convertWayPointsToPathWithLaneId( std::vector getReversingIndices(const PathWithLaneId & path); std::vector dividePath( - const PathWithLaneId & path, const std::vector indices); + const PathWithLaneId & path, const std::vector & indices); void correctDividedPathVelocity(std::vector & divided_paths); @@ -87,8 +87,8 @@ bool isCloseToPath(const PathWithLaneId & path, const Pose & pose, const double // only two points is supported std::vector splineTwoPoints( - std::vector base_s, std::vector base_x, const double begin_diff, - const double end_diff, std::vector new_s); + const std::vector & base_s, const std::vector & base_x, const double begin_diff, + const double end_diff, const std::vector & new_s); std::vector interpolatePose( const Pose & start_pose, const Pose & end_pose, const double resample_interval); diff --git a/planning/behavior_path_planner/autoware_behavior_path_planner_common/src/marker_utils/utils.cpp b/planning/behavior_path_planner/autoware_behavior_path_planner_common/src/marker_utils/utils.cpp index 8c9b4ef35d5af..d57c2339041f4 100644 --- a/planning/behavior_path_planner/autoware_behavior_path_planner_common/src/marker_utils/utils.cpp +++ b/planning/behavior_path_planner/autoware_behavior_path_planner_common/src/marker_utils/utils.cpp @@ -79,7 +79,7 @@ MarkerArray createFootprintMarkerArray( } MarkerArray createPointsMarkerArray( - const std::vector points, const std::string & ns, const int32_t id, const float r, + const std::vector & points, const std::string & ns, const int32_t id, const float r, const float g, const float b) { auto marker = createDefaultMarker( diff --git a/planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/path_utils.cpp b/planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/path_utils.cpp index 79b4ba8e16344..7873a4b421297 100644 --- a/planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/path_utils.cpp +++ b/planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/path_utils.cpp @@ -376,7 +376,7 @@ std::vector getReversingIndices(const PathWithLaneId & path) } std::vector dividePath( - const PathWithLaneId & path, const std::vector indices) + const PathWithLaneId & path, const std::vector & indices) { std::vector divided_paths; @@ -445,8 +445,8 @@ bool isCloseToPath(const PathWithLaneId & path, const Pose & pose, const double // only two points is supported std::vector splineTwoPoints( - std::vector base_s, std::vector base_x, const double begin_diff, - const double end_diff, std::vector new_s) + const std::vector & base_s, const std::vector & base_x, const double begin_diff, + const double end_diff, const std::vector & new_s) { assert(base_s.size() == 2 && base_x.size() == 2);