Fix mock usage #3519
Merged
Fix mock usage #3519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests used `assert mock_object.called_once_with()`. The return value of `called_once_with()` is a mock object which always evaluates to true which means it always passes the assertion.
cklein
force-pushed
the
u/cklein/fix_mock_usage
branch
from
651d1a3
to
fc03deb
Compare
nemacysts
approved these changes
Dec 28, 2022
gmdfalk
pushed a commit
to gmdfalk/paasta
that referenced
this pull request
Jun 26, 2023
Some tests used `assert mock_object.called_once_with()`. The return value of `called_once_with()` is a mock object which always evaluates to true which means it always passes the assertion.
This was referenced Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests used
assert mock_object.called_once_with(). The return value ofcalled_once_with()is a mock object which always evaluates to true which means it always passes the assertion.