Updated Finals Page #779
Updated Finals Page #779
Conversation
working on adding a delete button to remove selected courses
trying to fix modal functionality
disabled the delete button unless there is atleast 1 course. added the selected courses names and sections into modal
added removing courses functionality but for some reason it deletes the first item in the array instead of the selected course
deleting from modal works, but turning to create deletes for each item
can delete all courses except first, if course is null, "No Selected Courses" is displayed, small error where if no course is selected then cannot search for final exam
Got rid of buttons and select forms to make UI more user friendly. Only bug left is that when adding course if previous one is filled out then the 2nd course can be inputted as null in modal
attempting to add courses already on schedule to the finals page, not working yet
cleaned up finals page for potential pull request
sqlalchamey
There was a problem hiding this comment.
The feature works as intended, allowing the addition and deletion of finals. The page is done really nicely for easy access and convenience when changing a course. My only suggestion is that the delete button might be confusing for some people since they don't know what it is that is being deleted until they click on it. It might be better to label it 'Delete a course' and possibly put it below the 'Add Course' button so people know that it doesn't automatically delete their added courses.
There was a problem hiding this comment.
Looks great so far!
Two things:
- Instead of having a singular delete button, maybe have a per-class delete button, like an x in the top corned, above the course title?
- The buttons in the dialogs in this page have inconsistent styling compared to the rest of the website. Every other button is filled in, whereas these buttons only fill in when hovered on.
|
Attached are images of the updated UI addressing the requested changes. 
|
c-jimmy1
added
Review Ready!
|
Here is the Added Remove All Courses Button
Only appears when 2 or more courses are selected, which saves students clicks if they want to restart. |
OLD
NEW
Process: