Add Async API Tests for Timeout #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
commented
Feb 12, 2021
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/AsyncTest/AsyncTimeoutTest.cs
Outdated
Show resolved
Hide resolved
…syncTimeoutTest.cs
cheenamalhotra
commented
Feb 12, 2021
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/AsyncTest/AsyncTimeoutTest.cs
Outdated
Show resolved
Hide resolved
…syncTimeoutTest.cs
cheenamalhotra
commented
Feb 12, 2021
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/AsyncTest/AsyncTimeoutTest.cs
Outdated
Show resolved
Hide resolved
…syncTimeoutTest.cs
cheenamalhotra
commented
Feb 12, 2021
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
Outdated
Show resolved
Hide resolved
…ent/TdsParserStateObject.cs
Wraith2
reviewed
Feb 12, 2021
Comment on lines
3571
to
3599
| // Take lock and send attention | ||
| bool releaseLock = false; | ||
| if ((mustTakeWriteLock) && (!_parser.Connection.ThreadHasParserLockForClose)) | ||
| { | ||
| releaseLock = true; | ||
| _parser.Connection._parserLock.Wait(canReleaseFromAnyThread: false); | ||
| _parser.Connection.ThreadHasParserLockForClose = true; | ||
| } | ||
| try | ||
| { | ||
| // Check again (just in case the connection was closed while we were waiting) | ||
| if (_parser.State == TdsParserState.Closed || _parser.State == TdsParserState.Broken) | ||
| { | ||
| releaseLock = true; | ||
| _parser.Connection._parserLock.Wait(canReleaseFromAnyThread: false); | ||
| _parser.Connection.ThreadHasParserLockForClose = true; | ||
| return; | ||
| } | ||
| try | ||
| { | ||
| // Check again (just in case the connection was closed while we were waiting) | ||
| if (_parser.State == TdsParserState.Closed || _parser.State == TdsParserState.Broken) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| uint sniError; | ||
| _parser._asyncWrite = false; // stop async write | ||
| SNIWritePacket(attnPacket, out sniError, canAccumulate: false, callerHasConnectionLock: false); | ||
| SqlClientEventSource.Log.TryTraceEvent("<sc.TdsParser.SendAttention|INFO> Send Attention ASync."); | ||
| } | ||
| finally | ||
| uint sniError; | ||
| _parser._asyncWrite = false; // stop async write | ||
| SNIWritePacket(attnPacket, out sniError, canAccumulate: false, callerHasConnectionLock: false); | ||
| SqlClientEventSource.Log.TryTraceEvent("<sc.TdsParser.SendAttention|INFO> Send Attention ASync."); | ||
| } | ||
| finally | ||
| { | ||
| if (releaseLock) | ||
| { | ||
| if (releaseLock) | ||
| { | ||
| _parser.Connection.ThreadHasParserLockForClose = false; | ||
| _parser.Connection._parserLock.Release(); | ||
| } | ||
| _parser.Connection.ThreadHasParserLockForClose = false; | ||
| _parser.Connection._parserLock.Release(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Would you mind reverting this indentation change? The IDE isn't seeing inside the #ifdef's and is taking the block 1 step too far left as a result.
There was a problem hiding this comment.
I've fixed the brackets, so they won't bother again.
Wraith2
approved these changes
Feb 12, 2021
Wraith2
pushed a commit
that referenced
this pull request
Feb 24, 2021
* Removing BinaryFormatter from NetFx * review comments * fix version typo * remove extra line * Reverted SqlException Test * review comments * Review comment * Desrialize * addressing review comments * Fix exception in deserialization (#1) * review comments * add extra line to the end of strings designer * end of line Co-authored-by: jJRahnama <jrahnama@simba.com> Co-authored-by: Karina Zhou <v-jizho2@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests passing.