Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Remove redundant templates/parts #58

Open
3 tasks
iandunn opened this issue Oct 27, 2021 · 0 comments
Open
3 tasks

Gutenberg: Remove redundant templates/parts #58

iandunn opened this issue Oct 27, 2021 · 0 comments
Labels
[Status] Blocked (external) Blocked by something outside our direct control [Type] Developer Experience

Comments

@iandunn
Copy link
Member

iandunn commented Oct 27, 2021

There are cases where we've had to create new templates and template parts that are almost identical to existing ones, because we can't have simple logic inside the HTML files. Examples:

  • index.html and category.html are identical except for a few class slugs
  • content-post.html and content-page.html are identical except for the post terms. They could be a single singular.html with an if() around the terms block.

Once WordPress/gutenberg#32939 is resolved, we should be able to remove a lot of the WET stuff and make things simpler.

Similarly, there's some of duplicated markup:

@iandunn iandunn added the devex label Oct 27, 2021
@iandunn iandunn changed the title Remove redundant templates/parts Gutenberg: Remove redundant templates/parts Nov 4, 2021
@iandunn iandunn added the [Status] Blocked (external) Blocked by something outside our direct control label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Blocked (external) Blocked by something outside our direct control [Type] Developer Experience
Projects
None yet
Development

No branches or pull requests

1 participant