Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems when blogname is set to Chinese #1719

Closed
2551654928 opened this issue Aug 30, 2024 · 3 comments · Fixed by #1731
Closed

Problems when blogname is set to Chinese #1719

2551654928 opened this issue Aug 30, 2024 · 3 comments · Fixed by #1731
Labels
[Aspect] Website [Package][@wp-playground] Blueprints [Type] Bug An existing feature does not function as intended

Comments

@2551654928
Copy link

2551654928 commented Aug 30, 2024

{ "landingPage": "/wp-admin/", "siteOptions": { "blogname": "KEKC博客" }, "login": true }

@2551654928
Copy link
Author

20240830-114432.mp4

@adamziel
Copy link
Collaborator

adamziel commented Aug 30, 2024

Thank you for the report! The problem is likely here:

It calls just btoa, when it should be calling a utf8-compatible function like this one:

function bytesToBase64(bytes: Uint8Array) {
	const binString = String.fromCodePoint(...bytes);
	return btoa(binString);
}

The same goes for each btoa() and atob() call in the codebase. The earliest I'll be able to propose a fix is Thursday, but if you start a PR before then I'll be happy to review.

@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Package][@wp-playground] Blueprints [Aspect] Website labels Aug 30, 2024
@adamziel
Copy link
Collaborator

#1731 will solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Aspect] Website [Package][@wp-playground] Blueprints [Type] Bug An existing feature does not function as intended
Projects
None yet
2 participants