-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL and JS errors with Yoast SEO #1452
Comments
Hi @enricobattocchi, thank you for reporting this. Would it be possible to skip the indexing for the Playground Puzzle? If yes would you be able to update the Yoast blueprint with the missing code. Or share the code with me and I can make the change.
We don't have a way to do it today. |
Thanks @bgrgicak! Would it be enough for you to unblock Yoast SEO? |
Unfortunately we can't do that. It might mess up other plugins. |
This PR should fix the JS issue #1460 |
I see!
|
Thank you! I will add this to the blueprint. |
@bgrgicak do you think Yoast can be added to the Puzzle project with these fixes? |
Yes, we printed it. I just need to update the blueprint. What would be a good way to skip onboarding in Yoast? Because people will only casually explore the site we want to avoid any onboarding flows with puzzle pieces. |
Thanks @bgrgicak! 🎉 |
@bgrgicak if I launch https://playground.wordpress.net/?plugin=wordpress-seo I'm not redirected to our onboarding page... |
@enricobattocchi I wanted the onboarding to load if only Yoast is installed. But if we have multiple puzzle pieces I want to skip it. |
@enricobattocchi I tried adding Would you be able to help me build a blueprint that disables indexing and onboarding? Here is what I built.
|
Sure, I'll have a look |
hey @bgrgicak:
|
Thank you! I got it to work with this blueprint. I assume your code ran before Yoast was installed and the plugin overwrote the variable.
|
Running Yoast SEO on Playground is currently impossible due to some errors:
Javascript errors
When editing a post with Yoast SEO active, the metabox is not rendered correctly (only the tab headers are present). This likely caused by the errors you can see in the browser console:
The first one seems to be caused by a double injection of the
__playground_readBlobAsText
code not just into the WP Core, but also in the plugin'sblock-editor.js
file since unfortunately it shares the last part of the path that's used to identify where to inject that code.Could the path matching be made more unique to make sure only WP core and Gutenberg are targeted?
From what I can see, the second error is triggered by the first one preventing the correct initialization of the
window.yoast
object, so fixing the above would restore the metabox functionality.SQL errors
On plugin activation some DB queries fail due to unsupported syntax. It seems that some of them should be supported by SQLite according to the documentation, while others are legitimate MySQL queries that may require to be translated.
They are:
ALTER TABLE <table> ADD <column>
, whileALTER TABLE <table> ADD COLUMN <column>
seems to be working (docs)ALTER TABLE <table> CHANGE <column>
which doesn't seem to be supported in SQLite (docs)ALTER TABLE <table> CONVERT TO CHARACTER SET
which doesn't seem to be supported in SQLite (docs)CREATE INDEX <index>
andCREATE UNIQUE INDEX <index>
(docs)SHOW KEYS FROM <table>
which doesn't seem to be supported in SQLiteActually these queries are related to our custom Indexables tables, which are usually disregarded in non-production environments. We may make sure that they are unused in Playground too, but some of the queries may run and return errors: in this scenario, though, they would not be relevant. Would there be a way to silence those errors or let those queries fail gracefully?
The text was updated successfully, but these errors were encountered: