From 607572b5041d0670abd248dbbc79d37b306052c7 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Wed, 11 Sep 2024 07:27:34 +0200 Subject: [PATCH] Build/Test Tools: Enable running the tests on PHP 8.4 :warning: Please read Trac ticket 62061 - this PR can't be committed until other patches have been committed first! :warning: PHP 8.4 is expected to be released at the end of November 2024. Enabling the tests to run in CI on PHP 8.4 allows WordPress core to start getting ready. Note: Xdebug-related tests will not be run on PHP 8.4 at this time as the Docker image for PHP 8.4 does not contain Xdebug yet. Once a stable release of Xdebug 3.4.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.4. --- .github/workflows/phpunit-tests.yml | 4 ++-- .github/workflows/reusable-phpunit-tests-v3.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/phpunit-tests.yml b/.github/workflows/phpunit-tests.yml index 31d18f9b10efa..50e4c940c2169 100644 --- a/.github/workflows/phpunit-tests.yml +++ b/.github/workflows/phpunit-tests.yml @@ -45,7 +45,7 @@ jobs: fail-fast: false matrix: os: [ ubuntu-latest ] - php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ] + php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ] db-type: [ 'mysql' ] db-version: [ '5.7', '8.0', '8.1', '8.2', '8.3' ] tests-domain: [ 'example.org' ] @@ -116,7 +116,7 @@ jobs: fail-fast: false matrix: os: [ ubuntu-latest ] - php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ] + php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ] db-type: [ 'mariadb' ] db-version: [ '10.4', '10.6', '10.11', '11.2' ] multisite: [ false, true ] diff --git a/.github/workflows/reusable-phpunit-tests-v3.yml b/.github/workflows/reusable-phpunit-tests-v3.yml index c9387d06a8451..fcdf88280874d 100644 --- a/.github/workflows/reusable-phpunit-tests-v3.yml +++ b/.github/workflows/reusable-phpunit-tests-v3.yml @@ -182,7 +182,7 @@ jobs: # __fakegroup__ is excluded to force PHPUnit to ignore the settings in phpunit.xml.dist. - name: Run (Xdebug) tests - if: ${{ inputs.php != '8.3' }} + if: ${{ inputs.php != '8.4' }} continue-on-error: ${{ inputs.allow-errors }} run: LOCAL_PHP_XDEBUG=true node ./tools/local-env/scripts/docker.js run php ./vendor/bin/phpunit -v --group xdebug --exclude-group __fakegroup__