Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Rename blocks in patterns #515

Closed
MaggieCabrera opened this issue Sep 26, 2023 · 3 comments · Fixed by #637
Closed

Rename blocks in patterns #515

MaggieCabrera opened this issue Sep 26, 2023 · 3 comments · Fixed by #637
Labels
[Type] Enhancement New feature or request

Comments

@MaggieCabrera
Copy link
Collaborator

The rename block feature is going to land on 6.4, so I propose we use it on our patterns so they are clear to the users as to what they are. We can rename the main container of the pattern and in more complex ones any relevant sections (like rename the sidebar column and the main column on the templates that use them as layout!)

My main concern with this is that adding this may produce broken markup for the theme (which already happens for patterns that use new features like aspect ratio) if you are using a previous version of WordPress. What should we do about that?

Screenshot 2023-09-26 at 17 59 49
@luminuu
Copy link
Member

luminuu commented Sep 26, 2023

Every default theme so far has set the "Requires at least" to the actual version it was shipped with. Which means we can set TT4 to require at least WP 6.4, so it won't be installable on previous versions.

Love it that this finally comes to the editor and yes, we should update all our patterns with this one.

On checking the readme.txt and the style.css I noticed the style.css still has 6.0 there, it should be updated to 6.4.

@carolinan
Copy link
Contributor

I believe this is an enhancement, and while I don't mind the idea, I think the bug fixes need to be prioritized so that bugs are not shipped...

@MaggieCabrera MaggieCabrera added the [Type] Enhancement New feature or request label Sep 29, 2023
@MaggieCabrera
Copy link
Collaborator Author

Definitely, tagged as such. Sorry, I'm so bad at keeping my issues labeled!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants