Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate regions style improvements #8553

Closed
afercia opened this issue Aug 5, 2018 · 0 comments · Fixed by #8554
Closed

Navigate regions style improvements #8553

afercia opened this issue Aug 5, 2018 · 0 comments · Fixed by #8554
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Aug 5, 2018

When jumping through the main editor sections with the keyboard shortcut Ctrl + backtick there are a few things that could be improved:

1
When the posts or sidebar content is very long, scrolling the content or sidebar makes the focus style shape scroll too:

screen shot 2018-08-01 at 19 28 58

screen shot 2018-08-04 at 17 22 59

This happens because the focus style is set on a CSS pseudo element that scrolls together with the content because, well it's content. Ideally, the focus style should be set as an outline on the landmark regions so it's always visible regardless of scrolling.

2
When focusing the "Open publish panel" region, part of the content at the bottom of the page becomes not visible:

screen shot 2018-08-05 at 15 25 38

this happens because the "Open publish panel" region is relatively positioned and thus still takes space. Also, it would be nice to place the button in the same exact position of the "Skip to the selected block" button:

screen shot 2018-08-01 at 19 40 32

3
With Firefox, the "Open publish panel" region stays out of view when it receives focus.

4
Worth noting the current implementation uses :focus-within, not supported by IE11 and Edge. This part should be refactored to use just :focus.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Aug 5, 2018
@afercia afercia self-assigned this Aug 5, 2018
@afercia afercia removed their assignment Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant