Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block audit: Pullquote #8329

Closed
7 of 10 tasks
sarahmonster opened this issue Jul 31, 2018 · 3 comments
Closed
7 of 10 tasks

Block audit: Pullquote #8329

sarahmonster opened this issue Jul 31, 2018 · 3 comments
Assignees
Labels
[Block] Pullquote Affects the Pullquote Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@sarahmonster
Copy link
Member

sarahmonster commented Jul 31, 2018

Note: We'll be doing these audits in waves and editing this as we work through the blocks, so this text will be updated and fleshed out as we progress. See the full picture here.

Overview

screenshot 2018-07-31 19 24 40

Name: Pullquote
Description: Highlight a quote from your post or page by displaying it as a graphic element.
Category: Formatting blocks
CSS class: wp-block-pullquote in frontend or editor
Can be converted to: nothing

States

Empty:
screenshot 2018-07-31 19 16 08

Selected:
screenshot 2018-07-31 19 21 16

Unselected:
screenshot 2018-07-31 19 22 05

Placeholder:
screenshot 2018-07-31 19 16 02

Primary (toolbar) settings

Align: left, centre, right, bold, italic, strikethrough, link

Secondary (sidebar) settings

Advanced: Additional CSS Class

Frontend appearance

Gutenberg starter theme:
screenshot 2018-08-01 12 39 24
screenshot 2018-08-01 12 39 29

Atomic Blocks
screenshot 2018-08-01 12 43 11

twentyseventeen:
screenshot 2018-08-01 12 38 17

twentyten:
screenshot 2018-08-01 12 34 52

Bugs/errors

Individual issues will be opened for these soon

*Note that toggling italics works as expected here, where it doesn't with the quote block (and a few other blocks that use captions by default.)

Suggestions

Individual issues will be opened for these soon

  • My first instinct here is "why do we have two types of quotes, and how does a user decide which to use?" I know that a pull quote is designed to be a graphic element to highlight text from the articles, but I suspect most users don't. We should be careful how we present this block to avoid confusion. (See also Block audit: Quote #8236)

  • Further to that, the citation should probably be removed entirely. Since the intention of a pullquote is to quote from the article itself, a citation doesn't make sense in this context. (Having two types of quote is confusing #11610)

  • Use an <aside> rather than a <blockquote> makes more semantic sense here. Worth also considering the accessibility constraints here—ideally screen readers wouldn't read the content of a pull quote, since it's basically doubled-up content. (Aside for pullquotes rather than blockquote #5457)

  • An alternative solution would be to add the pull quote styles to the main quote block, which is probably the easiest and best solution here. (Consider whether Pullquote should be a separate block, a style of quotes, or vice versa #5947)

  • Italic all-caps feels like a pretty awkward style choice for the citation styling, and it's inconsistent with the rest of Gutenberg. Generally the styling feels out-of-place and discordant.

  • If we decide to keep it, it should definitely be convertible to a regular quote.

  • Probably shouldn't use the same icon as the quote block.

  • Could be confusing that this uses image-style alignment icons and functionality, whereas the quote element uses the text-style alignment icons and functionality.

@sarahmonster sarahmonster self-assigned this Jul 31, 2018
@sarahmonster sarahmonster added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Blocks Overall functionality of blocks labels Jul 31, 2018
@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Jul 31, 2018

Further to that, the citation should probably be removed entirely. Since the intention of a pullquote is to quote from the article itself, a citation doesn't make sense in this context.

I agree.

Use an <aside> rather than a <blockquote> makes more semantic sense here.

I think both should be used here: a <blockquote> nested in an <aside>.

My first instinct here is "why do we have two types of quotes, and how does a user decide which to use?" I know that a pull quote is designed to be a graphic element to highlight text from the articles, but I suspect most users don't. We should be careful how we present this block to avoid confusion. (See also #8236)

An alternative solution would be to add the pull quote styles to the main quote block, which is probably the easiest and best solution here. (#5947)

Block styles currently can only add a class to a block. They cannot change the rest of the markup, so I do not think that having a pullquote be a style of the Quote block makes sense, unless the block styles API is changed to support markup changes, which I think may be a bad idea.

Could be confusing that this uses image-style alignment icons and functionality, whereas the quote element uses the text-style alignment icons and functionality.

Something I wonder about is what blocks should have float alignment options and why? I am not aware of any standard reasoning for whether or not a block should have the float alignment options, or even alignment options in general.

@ZebulanStanphill
Copy link
Member

Thinking about it some more, I think the Pullquote block may not be necessary at all. If the proposed Container block was implemented with the ability to change the HTML element used from <div> to <aside>, you could make a semantically correct equivalent to the Pullquote block using a Quote block nested in a Container block saved as a Reusable block that would be used as a template. See also: #8403.

The only thing that would be missing is the style of the current Pullquote block, but that could just be added as another style variation of the Quote block.

This brings up another question: should core include some Reusable blocks on new installations to be used as templates, in cases where there is a common piece of content that can be constructed out of existing blocks?

@sarahmonster sarahmonster added the [Block] Pullquote Affects the Pullquote Block label Nov 8, 2018
@sarahmonster
Copy link
Member Author

Thanks for the discussion and ideas here! I've filed some additional suggestions re: the quote/pullquote confusion over in #11610 for further discussion.

All other issues identified here have been filed as individual issues, so I'm going to go ahead and close out this tracking bug. Feel free to comment if I missed anything, or open new issues as needed! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pullquote Affects the Pullquote Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

2 participants