Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery Block: Add Multiple Styles #744

Closed
mkaz opened this issue May 9, 2017 · 5 comments
Closed

Gallery Block: Add Multiple Styles #744

mkaz opened this issue May 9, 2017 · 5 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media Needs Design Needs design efforts. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Question Questions about the design or development of the editor.

Comments

@mkaz
Copy link
Member

mkaz commented May 9, 2017

Add multiple styles for laying out the gallery block.
Two initial styles are Tile (default) and Masonry layout.
A potential additional style could be slideshow

See #317 and #740
@jasmussen jasmussen added [Feature] Blocks Overall functionality of blocks Design [Type] Question Questions about the design or development of the editor. labels May 10, 2017
@mtias
Copy link
Member

mtias commented May 16, 2017

I think slideshow should be a separate block.

@mrwweb
Copy link

mrwweb commented May 16, 2017

Related: #783

@jasmussen jasmussen added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label May 31, 2017
@mtias mtias added the [Feature] Media Anything that impacts the experience of managing media label Jun 29, 2017
@karmatosed karmatosed added the Needs Design Needs design efforts. label Jul 10, 2017
@karmatosed karmatosed mentioned this issue Jul 20, 2017
Closed
@mtias
Copy link
Member

mtias commented Aug 4, 2017

We already implemented a tiled gallery design by default which is fairly flexible with cropping and columns.

@mtias mtias closed this as completed Aug 4, 2017
@feeela
Copy link

feeela commented Oct 19, 2018 •
edited
Loading

I think slideshow should be a separate block.

I though blocks would refer to the content. A slideshow is a gallery, when speaking of the content. It is just presented in another form. In fact, there mustn't even be differences in the HTML, beside some data-* attribute to indicate, that a JS plugin should displya this gallery as a slideshow.

@mtias
Copy link
Member

mtias commented Oct 22, 2018

Blocks refer to what is meaningful to a user to discover and use. Different blocks can have the same HTML markup but different expectations and different UIs.

This was referenced Feb 16, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media Needs Design Needs design efforts. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Question Questions about the design or development of the editor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mkaz @karmatosed @mtias @feeela @jasmussen @mrwweb