Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View: drag and drop animation is unexpected #63518

Open
ellatrix opened this issue Jul 13, 2024 · 2 comments
Open

List View: drag and drop animation is unexpected #63518

ellatrix opened this issue Jul 13, 2024 · 2 comments
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended

Comments

@ellatrix
Copy link
Member

Description

When dragging a block to a position, it is already moved into the right position. It does not make sense to animate it (which involves reverting the dragging, then animating it into the right position).

The current state looks glitchy:

list-view-drag-drop-animation

Step-by-step reproduction instructions

Drag and drop any block in List View.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ellatrix ellatrix added [Type] Bug An existing feature does not function as intended [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Jul 13, 2024
@ellatrix
Copy link
Member Author

Looking at this more, I feel like more things are wrong:

  • Instead of an indicator line, it displaces the blocks on dragging, which contributes to the glitchiness.
  • The drag chip should ideally be the list view item, for a smoother experience.

@andrewserong
Copy link
Contributor

Thanks for opening this one Ella!

There is a tracking issue here for list view work: #49563. In particular for making the drag chip resemble the list view item, there is a bit of history for it over here:

The current state of that PR is the following, it's still a bit glitchy though:

2024-07-08.14.03.10.mp4

Also discussed a little over in #63174 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants