Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Clear customisations" template action should always trigger a confirmation dialog #60072

Closed
jameskoster opened this issue Mar 21, 2024 · 2 comments
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Extracted from discussion in #56603.

If you perform the "Clear customisations" action in the details panel, or the document inspector, a confirmation dialog appears asking if you're sure whether to proceed.

However, in the templates data view there's no confirmation dialog.

It would be good to be consistent here, and introduce the confirmation dialog in the templates data view.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Mar 21, 2024
@annezazu
Copy link
Contributor

Somewhat related as there are a few reset mechanism that would benefit from this: #46859

@jameskoster
Copy link
Contributor Author

This was fixed in #60119.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants