Search Block: Button styles don't save when placed inside a Navigation block

[ndiego]

Description

If you place a Search block inside of a menu in a Navigation block, then set the block to "Button only" (or any other option besides "Button inside"), the style is not persisted when the Navigation menu is saved. The Search block reverts to "Button inside". See the gif below.

Step-by-step reproduction instructions

1. Create a Navigation menu
2. Save the Navigation menu
3. Add a Search block to the menu
4. Set the Search block to "Button only" (or any other option besides "Button inside")
5. Save the Navigation menu and see that the Search block is no longer set to "Button only"

Screenshots, screen recording, code snippet

Environment info

• WordPress 6.3 RC2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[ndiego]

cc @getdave I think you have been working on Navigation. Any ideas here?

[getdave]

@scruffian wasn't this a bug you and I were looking into at one point? It was to do with random effects in the search block firing?

Did we miss a backport?

[tellthemachines]

Is this a duplicate of #51713? In any case, I can reproduce it in 6.2.2 so it's not a 6.3 regression.

[ndiego]

Is this a duplicate of #51713? In any case, I can reproduce it in 6.2.2 so it's not a 6.3 regression.

And apparently, I commented on that issue!?! 😅 That said, I am still able to replicate in Gutenberg 16.3, so the linked PR did not resolve the issue even though it is closed.

As for 6.3, since this issue is present in 6.2 and therefore not a regression, let's punt.

[wayneconnor]

Is there a work around for this in the meantime?

[ramonjd]

I couldn't reproduce this specific issue in Chrome, Edge, Firefox or Safari but was experiencing some other strange behaviour. When trying to add text to an empty search block rich text field I couldn't at all. It would bounce focus away from the button.

2023-09-25.13.14.56.mp4

[tellthemachines]

I can reproduce the issue only when first adding a Search block in a Nav block; saving and reloading or even just switching to code view and back restores the expected behaviour.

search-in-nav.mov

[getdave]

@ramonjd @tellthemachines I have a PR for review 🙏

[ramonjd]

Thanks for tracking it down @getdave !