Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Control - fix TAB selects suggestion #51732

Closed
getdave opened this issue Jun 21, 2023 · 1 comment
Closed

Link Control - fix TAB selects suggestion #51732

getdave opened this issue Jun 21, 2023 · 1 comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Jun 21, 2023

In the LinkControl component pressing TAB when search results are displayed causes the first result to be selected. This behaviour is not correct.

Rather the TAB should move focus and nothing else should happen.

We need to address:

  • keyboard arrow keys do not work add visual states for aria-selected
  • pressing TAB when in input results in selection of that result this is present in trunk.
@getdave getdave added [Type] Bug An existing feature does not function as intended [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Jun 21, 2023
@getdave getdave mentioned this issue Jun 21, 2023
Merged
5 tasks
@getdave
Copy link
Contributor Author

getdave commented Dec 14, 2023

Screen.Capture.on.2023-12-14.at.09-40-19.mp4

I came here circling back to see if I could fix. I gave this another test and it appears to have been fixed. If I press TAB I am kept within the search input and I move to the Submit button.

Only when the search input is focused and I press the ARROW keys will I move out of the search input.

@getdave getdave closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@getdave