Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Edit template' command appears out of context #51688

Closed
jameskoster opened this issue Jun 20, 2023 · 2 comments · Fixed by #51888
Closed

'Edit template' command appears out of context #51688

jameskoster opened this issue Jun 20, 2023 · 2 comments · Fixed by #51888
Assignees
@noisysocks
Labels
[Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

When you're editing a page in the site editor, a contextual 'Edit template' suggestion appears when you open the command palette. Clicking this enables you to edit the template associated with the current page.

This 'Edit template' command also appears outside of the fullscreen editor if you search, and clicking it will do nothing:

Screenshot 2023-06-19 at 13 41 34

It probably makes sense to only surface this command in edit view, when you're editing a page.

cc @noisysocks
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 20, 2023
@richtabor
Copy link
Member

richtabor commented Jun 20, 2023 •
edited
Loading

An aside, but it would be nice if the template name was included in this commands. I.e. "Edit Index template". Related: #51693

@noisysocks noisysocks added the [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. label Jun 26, 2023
@noisysocks noisysocks mentioned this issue Jun 26, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 26, 2023
@noisysocks
Copy link
Member

@richtabor I'll note that in #51693.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noisysocks noisysocks

Labels
[Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only show Page Content Focus commands when in edit mode WordPress/gutenberg
4 participants
@noisysocks @jameskoster @richtabor @priethor