Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Theme Previews: hide "View" when in the Edit View #50919

Open
annezazu opened this issue May 24, 2023 · 1 comment
Open

Block Theme Previews: hide "View" when in the Edit View #50919

annezazu opened this issue May 24, 2023 · 1 comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

This was raised by @carolinan as part of the FSE Outreach Program's Rapid Revamp call for testing:

Once in edit mode, with the navigation sidebar closed, I found the Activate button in the same area as the save button, but there is also a View site option in the “View” modal next to it, and using that feature shows the currently active theme, not the theme that is being previewed. Perhaps that last option in the View modal could be disabled while previewing.

This refers to the following:

Screen Shot 2023-05-24 at 9 26 37 AM

Let's consider hiding this entirely when someone is previewing a theme!

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels May 24, 2023
@scruffian
Copy link
Contributor

The other option is to just add the theme_preview parameter to that link so that it actually works as a preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants