Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] should have tabs containing block examples #50838

Closed
github-actions bot opened this issue May 22, 2023 · 1 comment · Fixed by #51365
Closed

[Flaky Test] should have tabs containing block examples #50838

github-actions bot opened this issue May 22, 2023 · 1 comment · Fixed by #51365
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented May 22, 2023 •
edited
Loading

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should have tabs containing block examples

Test path

/test/e2e/specs/site-editor/style-book.spec.js

Errors

[2023-05-22T10:55:40.935Z] Test passed after 1 failed attempt on trunk.
[2023-05-22T14:55:15.393Z] Test passed after 1 failed attempt on trunk.
[2023-05-23T09:48:39.379Z] Test passed after 1 failed attempt on improve/has-resolving-selectors-selector.
[2023-05-23T13:14:11.466Z] Test passed after 1 failed attempt on trunk.
[2023-05-23T14:56:53.964Z] Test passed after 1 failed attempt on add/test-coverage-for-comments-template-block-context.
[2023-05-23T15:13:52.377Z] Test passed after 1 failed attempt on try/navigation-menu-focus-mode-experiment.
[2023-05-24T05:25:23.539Z] Test passed after 1 failed attempt on try/adding-pattern-part-block.
[2023-05-25T05:38:33.671Z] Test passed after 1 failed attempt on fix/undo-redo.
[2023-05-25T11:35:53.219Z] Test passed after 1 failed attempt on fix/iframe-writing-flow-tab.
[2023-05-25T14:25:48.717Z] Test passed after 1 failed attempt on fix/iframe-writing-flow-tab.
[2023-05-25T16:38:50.791Z] Test passed after 1 failed attempt on experiment/remove-interactivity-api-experimental-flag.
[2023-05-26T14:11:52.418Z] Test passed after 1 failed attempt on trunk.
[2023-05-26T14:45:43.414Z] Test passed after 1 failed attempt on try/improve-link-ui-entry-type-matching.
[2023-05-29T05:30:34.119Z] Test passed after 1 failed attempt on fix/firefox-screen-reader-aria-describedby.
[2023-05-29T13:48:11.235Z] Test passed after 1 failed attempt on update/eager-map-private-selectors.
[2023-05-29T16:46:40.484Z] Test passed after 1 failed attempt on trunk.
[2023-05-30T14:34:27.454Z] Test passed after 1 failed attempt on rnmobile/add-columns-test.
[2023-05-30T20:58:44.286Z] Test passed after 1 failed attempt on enhance/range-control-size.
[2023-05-31T06:10:15.562Z] Test passed after 1 failed attempt on fix/missing-styles-on-fresh-page-load.
[2023-05-31T12:59:32.899Z] Test passed after 1 failed attempt on feat/dropdownmenu-v2-toolbar-styles.
[2023-05-31T16:19:24.325Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T06:19:00.233Z] Test passed after 1 failed attempt on rnmobile/release_1.96.1.
[2023-06-01T06:59:05.927Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T08:14:33.265Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T11:32:03.282Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T11:45:33.558Z] Test passed after 1 failed attempt on update/data-action-binding.
[2023-06-01T11:51:52.763Z] Test passed after 1 failed attempt on try/additional-block-contents-component.
[2023-06-01T15:51:26.141Z] Test passed after 1 failed attempt on update/eager-map-private-selectors.
[2023-06-01T16:27:06.499Z] Test passed after 1 failed attempt on update/data-selector-binding.
[2023-06-02T02:23:06.234Z] Test passed after 1 failed attempt on trunk.
[2023-06-02T04:43:31.563Z] Test passed after 1 failed attempt on trunk.
[2023-06-02T06:08:56.364Z] Test passed after 1 failed attempt on trunk.
[2023-06-02T13:13:24.457Z] Test passed after 1 failed attempt on update/data-selector-binding.
[2023-06-02T13:57:49.032Z] Test passed after 1 failed attempt on browse-mode-navigation-options.
[2023-06-06T02:26:24.411Z] Test passed after 1 failed attempt on try/adding-non-synced-pattern-to-reusable-block-cpt.
[2023-06-06T06:56:25.683Z] Test passed after 1 failed attempt on update/save-hub-behaviour.
[2023-06-06T23:27:04.845Z] Test passed after 1 failed attempt on try/adding-non-synced-pattern-to-reusable-block-cpt.
[2023-06-07T06:27:53.976Z] Test passed after 1 failed attempt on try/site-editor-library.
[2023-06-07T06:50:22.346Z] Test passed after 1 failed attempt on try/template-block.
[2023-06-07T11:46:12.851Z] Test passed after 1 failed attempt on refactor/playwright-performance-tests.
[2023-06-07T18:46:33.186Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T00:55:54.682Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T02:05:37.400Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T05:33:40.790Z] Test passed after 1 failed attempt on try/table-view.
[2023-06-08T09:45:26.641Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T19:33:41.446Z] Test passed after 1 failed attempt on feat/toggle-group-control-framer-motion-shared-layout.
[2023-06-08T20:56:55.685Z] Test passed after 1 failed attempt on try/link-control-show-suggestions-on-dirty.
[2023-06-09T01:25:18.883Z] Test passed after 1 failed attempt on try/adding-non-synced-pattern-to-reusable-block-cpt.
[2023-06-09T05:05:11.648Z] Test passed after 1 failed attempt on fix/remove-select-hack-from-getBlockEditingMode.
[2024-02-02T23:02:49.238Z] Test passed after 1 failed attempt on trunk.
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label May 22, 2023
github-actions bot referenced this issue May 22, 2023
@getdave
Remove all edit functionality from Navigation in Browse Mode (#50788)
801681b 
* Remove Add Submenu option

* Remove Link UI entirely
github-actions bot referenced this issue May 22, 2023
@hellofromtonya
[Fonts API] Automatically enqueue user-selected global fonts (#50529)
ffc592a 
* Adds user-select fonts enqueuer.

* Auto queue before printing

* Always set $handles to false when empty

When invoked as a hooked callback, it receives an empty string.
Empty is the same as false.

* Use WP_Theme_JSON_Resolver_Gutenberg::get_user_data().

From PR #50499.
Props @oandregal.

* Adds print tests. Moves datasets to trait.
@github-actions github-actions bot mentioned this issue May 23, 2023
Merged
github-actions bot referenced this issue May 23, 2023
@felixarntz
Introduce prepend_to_selector() to avoid additional if checks and f…
58a22ce 
…ollow single responsibility principle (#50266)

* Introduce prepend_to_selector() method to avoid additional if checks and follow single responsibility principle.

* Don't call append_to_selector() when selector is likely empty.

* Remove parameter completely instead of deprecating.

* Correct doc block.
This was referenced May 23, 2023
Merged
Merged
Closed
Merged
Merged
Closed
github-actions bot referenced this issue May 26, 2023
@ellatrix
Iframe: remove obsolete readyState checks (#51003)
1a2d5f6
This was referenced May 26, 2023
Merged
Merged
Merged
github-actions bot referenced this issue May 29, 2023
@ntsekouras
Properly decode new template title in snackbar (#51057)
2746bda
This was referenced May 30, 2023
Merged
Merged
Merged
Merged
github-actions bot referenced this issue May 31, 2023
@ciampo
DropdownMenu v2: change default placement to match the legacy Dropdow…
172366a 
…nMenu component (#51133)

* Update docs

* CHANGELOG
@github-actions github-actions bot mentioned this issue Jun 1, 2023
Merged
github-actions bot referenced this issue Jun 1, 2023
@ramonjd
Fluid typography: ensure max viewport width is used in the editor (#5…
a993bfd 
…1146)

* #49815 added `settings.layout.wideSize` as the default value for the maximum viewport size in relation to calculating fluid fontsize values.
Unfortunately this maxViewPortWidth value was not being passed to `getTypographyFontSizeValue()`
This commit correct this omission and adds extra unit tests to both the JS and PHP versions.

* To avoid backwards compat problems I'm trying to keep the function signature the same, hence the gymnastics here.
Because we support fluid: true and fluid: {...values}, we have to ensure the param object is correctly set so that we can know if fluid typography is enabled or not.
The alternative could be a third argument to the `getTypographyFontSizeValue()` function, e.g., `isFluidEnabled`

* My blod is typo

* Why chain? Break the chains!
github-actions bot referenced this issue Jun 1, 2023
@derekblank
Replace react-native-hr library (#51041)
8ee14b0 
* Update native HorizontalRule primitive component
* Remove react-native-hr package references
github-actions bot referenced this issue Jun 1, 2023
@rmorse @ndiego
Update README.md on SlotFills to add info + example about the prop `f…
dca6a9c 
…illProps` (#51013)

* Update README.md

Add info and example about `fillProps` prop on `Slot`

* Update packages/components/src/slot-fill/README.md

Co-authored-by: Nick Diego <nickmdiego@gmail.com>

* Update packages/components/src/slot-fill/README.md

Co-authored-by: Nick Diego <nickmdiego@gmail.com>

---------

Co-authored-by: Nick Diego <nickmdiego@gmail.com>
This was referenced Jun 1, 2023
Merged
Merged
Merged
github-actions bot referenced this issue Jun 2, 2023
@noisysocks
Improvements to how blocks with a 'disabled' editing mode behave (#51148
d378185 
)

- Prevent DefaultAppender from appearing in a disabled block.
- Disable selection (using user-select: none) in disabled blocks.
- Prevent blocks from being inserted into a disabled block via global inserter.
- Prevent disabled blocks from being removed via keyboard shortcut.
- Prevent disabled blocks from being moved via List View drag and drop.
- Prevent block overlay from appearing on a disabled block.
github-actions bot referenced this issue Jun 2, 2023
@tellthemachines
Add block spacing and layout to Post Template (#49050)
555749a 
* Add static column number option

* Address feedback and fix Group placeholder

* Revert non-responsive option

* Try using grid layout in Post Template

* Update Post Template to use auto-fill columns

* Add block spacing to post template

* Show gap control by default

* Add unstable columns grid property

* Rename layout column attribute.

* Add a media query to reproduce current responsiveness

* Move layout controls to Post Template block

* Reduce max columns to 6.

* Remove unstable prefix

* fix cols breaking out of container

* Try adding deprecation

* Fix broken loop

* Update fixtures

* Code improvements

* Add some comments to the CSS.

* Add back deleted line

* Remove legacy attributes in deprecation

* Fix deprecation logic

* Update fixtures

* Fallback gap for classic themes

* fix spacing

* match old default value

* Update PHP test strings.

* Fix tag discrepancy in fixtures
github-actions bot referenced this issue Jun 2, 2023
@noisysocks @SaxonF @ramonjd
Site Editor: Add ability to focus on editing a page's content vs the …
362475d 
…page's template (#50857)

* Add ability to prevent editing blocks using useBlockEditingMode()

* Make useBlockEditingMode use context

* Remove rootBlockEditingMode setting

* Fix private createRegistrySelector selectors

* Consolidate templateLock=contentOnly logic into getBlockEditingMode

* Hide disabled blocks from List View

* Hide disabled blocks from breadcrumbs

* Add doc comments

* Add unit tests

* Use @typedef to document mode param

* Restore packages/components/package.json from trunk

* Restore packages/block-library/src/post-title/edit.js from trunk

* Move BlockListBlockContext out of block.js so that it exists on mobile platforms

* Site Editor: Add ability to focus on editing a page's content vs the page's template

* Show page information in DocumentActions

* Implement Content panel

* Prevent block overlay on disabled blocks

* Fix Navigation block being selectable

* Show 'Page' in breadcrumbs when focused on editing page

* Update post title, post featured image, and post content blocks to say 'Page' instead of 'Post'

* toolbar title styling

* Remove removePostFromContentBlockLabels for now

* Fix being able to select text within disabled blocks

* Hide BlockAppender when block is disabled

* Fix comments block in non-post templates

* Update template card selector in E2E tests

* Fix 'Add submenu' button in Navigation block

* Remove unhelpful comments

* Remove more unnecessary comments

* Use constant for block types array

* Use BEMish selectors

* Be explicit that we're switching away from the page lock

* Update removePageFromBlockContext() test

* Fix post context from appearing in Edit Template preview

We have to set postId and postType to null for the preview and omit them
in the editor. No point having helper methods, therefore.

* Clear block selection when switching from template focus to page focus

* Prevent insertion into a disabled block

* Don't allow removing and moving children of disabled blocks

* Work around @wordpress/data bug by not using createRegistrySelector() for now

* Fix typo

* Fix select() mock

* Fix block-editor selector tests

* Revert block-editor changes

* Improve useDisableNonContentBlocks performance

* Fix performance tests

---------

Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com>
Co-authored-by: ramon <ramonjd@gmail.com>
This was referenced Jun 2, 2023
Merged
Merged
Merged
Merged
Closed
Merged
github-actions bot referenced this issue Jun 7, 2023
@gutenbergplugin
Update Changelog for 16.0.0-rc.1
ecdbb9b
github-actions bot referenced this issue Jun 8, 2023
@noisysocks
Rename 'page content lock' to 'page content focus' (#51280)
fd19c59
github-actions bot referenced this issue Jun 8, 2023
@glendaviesnz
Only show view site link in view mode (#51279)
3df429f
@github-actions github-actions bot mentioned this issue Jun 8, 2023
Merged
github-actions bot referenced this issue Jun 8, 2023
@ciampo
Use internal context system to apply toolbar variant to toolbar dropd…
f1d0bd5 
…owns (#51154)

* DropdownMenu: read variant from context

* Toolbar: do not set `variant` prop on popover (rely on context system instead)

* Use named export for better storybook doc generation

* Provide context value in more toolbar components

* Hook Dropdown into context system, update DropdownMenu and CircularOptionPicker

* Remove toolbar variant popover prop where the context system can be used instead

* Add comment where the context system currently doesn't work

* Use placement prop instead of legacy "position" prop

* Add some temporary TODO comments

* Set toolbar variant for Dropdown in the context system

* Remove explicit variant prop from block alignment matrix control

* Toolbar: Only set context in the top-level component

* Remove `toolbar` variant from instances using `Dropdown`

* Simplify Dropdown implementation

* Tidy up types

* Remove toolbar variant storybook example for Popover

* CHANGELOG

* Complete renaming internal type

* Remove duplicate hardcoded classnames(already added by context connexct)
This was referenced Jun 8, 2023
Merged
Merged
Closed
@kevin940726 kevin940726 mentioned this issue Jun 9, 2023
Merged
@github-actions github-actions bot reopened this Feb 2, 2024
github-actions bot referenced this issue Feb 2, 2024
@getdave @anton-vlasenko @hellofromtonya
Update Font Library non-REST API code to align with Core standards (#…
408c118 
…58607)

* Apply fixes.

* Revert "Apply fixes."

This reverts commit d16d226.

* Remove variable.

* Small fixes.

* Fix phpdoc block.

* Fix typo.

* Apply reverted fixes.

* Apply reverted fixes.

* Apply reverted fixes.

* Apply reverted fixes.

* Apply reverted fixes.

* Initializes rest routes.

---------

Co-authored-by: Anton Vlasenko <vlasenko.anton@gmail.com>
Co-authored-by: Anton Vlasenko <anton@antons-mac-mini.local>
Unlinked contributors: anton@antons-mac-mini.local.

Co-authored-by: anton-vlasenko <antonvlasenko@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: hellofromtonya <hellofromtonya@git.wordpress.org>
Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: pbking <pbking@git.wordpress.org>
@github-actions GitHub Actions
Copy link
Author

This issue has gone 15 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Feb 19, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Styles Navigation Screen: close style book using location WordPress/gutenberg
0 participants