Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: Component CHAGELOG update check fails on PR from forked repository #49817

Closed
t-hamano opened this issue Apr 14, 2023 · 2 comments · Fixed by #49906
Closed

Workflows: Component CHAGELOG update check fails on PR from forked repository #49817

t-hamano opened this issue Apr 14, 2023 · 2 comments · Fixed by #49906
Assignees
Labels
GitHub Actions Pull requests that update GitHub Actions code [Package] Components /packages/components [Type] Build Tooling Issues or PRs related to build tooling

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Apr 14, 2023

Description

Tested on #49816

A workflow has been introduced in #49443 to check for updates to the CHANGELOG file of component packages. This workflow does not appear to work for PRs submitted from forked repositories.

Step-by-step reproduction instructions

The complete procedure I followed is as follows:

  • Clone the Gutenberg repository on GitHub
  • Run git clone https://github.com/{my-username}/gutenberg.git
  • Make changes to the .js file in the components package
  • Commit, push, and submit a PR
  • Confirm @wordpress/components CHANGELOG update runs
  • Workflow fails (expected)
  • Make changes to the /packages/components/CHANGELOG.md file
  • Commit and push
  • Confirm @wordpress/components CHANGELOG update runs
  • Workflow fails (not expected)
@t-hamano t-hamano added [Type] Build Tooling Issues or PRs related to build tooling [Package] Components /packages/components GitHub Actions Pull requests that update GitHub Actions code labels Apr 14, 2023
@t-hamano
Copy link
Contributor Author

It might be necessary to rewrite part of the GitHub Action, like this PR

fix: ce spec action for PRs from forks by vishnu-narayanan · Pull Request #4587 · chatwoot/chatwoot

@chad1008
Copy link
Contributor

Thanks for testing and troubleshooting @t-hamano, that does indeed look like exactly what we needed. I've made the necessary change in #49906 and it's testing well for me from a forked repo!

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions Pull requests that update GitHub Actions code [Package] Components /packages/components [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants