Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate duotone block support attributes under filter instead of color #49340

Open
ajlende opened this issue Mar 24, 2023 · 0 comments
Open

Migrate duotone block support attributes under filter instead of color #49340

ajlende opened this issue Mar 24, 2023 · 0 comments
Labels
[Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.

Comments

@ajlende
Copy link
Contributor

ajlende commented Mar 24, 2023

Duotone filters were initially added under color support when they were only part of block supports and theme.json presets. Then, when global styles support was added, that functionality was nested under filter instead. #34667 (comment)

I lean towards styles.filters.duotone conceptually even if we were to have settings.color.palette.duotone for a palette definition it’s conceivable duotone palettes could be used for more than duotone filters either as gradient backgrounds or masks or something else

When the global styles duotone filters were added under filter, the block supports should have followed since they involve CSS filters, specifically. This will prevent some confusion that comes from the lack of consistency with that reasoning.

The duotone attribute store in style.color.duotone needs to move to style.filter.duotone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants