Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Navigation panel does not update as expect with template menu changes. #48897

Closed
ndiego opened this issue Mar 7, 2023 · 10 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@ndiego
Copy link
Member

ndiego commented Mar 7, 2023

Description

In testing WordPress 6.2 Beta 5, I discovered a potential issue with the Navigation panel. The panel does not appear to update consistently when changes are made to the primary navigation in a template. I am wondering if this behavior is expected given #48689, but if so, I am confused about how to update the Navigation panel with a new "primary" menu. The video below better illustrates this issue 😅

Step-by-step reproduction instructions

  1. In the Site Editor, add a menu to a template. This menu should reflect in the Navigation panel.
  2. Then create a new menu and replace the previous menu.
  3. The new menu does not reflect in the Navigation panel.

Screenshots, screen recording, code snippet

switching-navigation-menus.mp4

Environment info

  • WordPress 6.2 Beta 5

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ndiego ndiego added [Type] Bug An existing feature does not function as intended Needs Testing Needs further testing to be confirmed. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 7, 2023
@ndiego
Copy link
Member Author

ndiego commented Mar 7, 2023

cc @Mamaduka @ntsekouras @scruffian

@Mamaduka
Copy link
Member

Mamaduka commented Mar 8, 2023

@ndiego, I believe this is intentional.

Based on recent changes in #48689:

Always pick the latest published manu and ignore the loaded template (the menu is higher order than the frame)

@jameskoster
Copy link
Contributor

Oh yes, this was intentional. The Navigation panel is supposed to always display the main menu, and never change. It was confusing to find different menus represented there based on seemingly random actions.

We still need to somehow indicate which menu is the main one in the UI though (#48891).

@ndiego
Copy link
Member Author

ndiego commented Mar 8, 2023

Oh yes, this was intentional. The Navigation panel is supposed to always display the main menu, and never change. It was confusing to find different menus represented there based on seemingly random actions.

@jameskoster fair enough, but we also need a way for users to define what the primary menu is and change it. As far as I can tell, there is no way to set this anywhere in the UI.

@ndiego ndiego removed the Needs Testing Needs further testing to be confirmed. label Mar 8, 2023
@jameskoster
Copy link
Contributor

I agree. But that is a bigger item and unlikely to make it into 6.2.

@ndiego
Copy link
Member Author

ndiego commented Mar 8, 2023

I agree. But that is a bigger item and unlikely to make it into 6.2.

Yup, we are already basically out of time. I am still concerned about this current flow. It is not obvious what menu is presented in the panel and how to change it. This confusion also surfaced in today's core-editor meeting.

@jameskoster
Copy link
Contributor

I think it would help if we marked the main menu somehow. But yeah, we're basically out of time even for small changes like that :(

@annezazu
Copy link
Contributor

annezazu commented Mar 8, 2023

Just want to underscore this feedback and reiterate how confusing the experience is. Here's a quick video demonstrating how odd it is to know which menu will show up and why.

menu.appearing.mov

@Mamaduka
Copy link
Member

The navigation panel was removed in 6.2, punting it to the next major release.

@getdave
Copy link
Contributor

getdave commented Jun 14, 2023

So folks are aware the Navigation panel has been updated to show a list of menus which will allow you to select the most appropriate one.

If there is only a single menu then it will just show that directly.

I think we can close this one out.

@getdave getdave closed this as completed Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

5 participants