Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover position is off on Safari with a Classic theme and when using the keyboard #48364

Open
afercia opened this issue Feb 23, 2023 · 0 comments
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented Feb 23, 2023

Description

Noticed while testing #42187

This appears to happen only with Safari and only when:

  • The active theme is a classic theme.
  • Only on some popovers, when using the keyboard.

I'm not sure what the root cause is. From a quick look, I'm not sure the popover calculation takes into account the case when the post editor has no iframe (with a Classic theme).

Step-by-step reproduction instructions

  • Use Safari.
  • Activate a Classic theme e.g. Twenty Twenty-One.
  • Go to the post editor ad click on a paragraph.
  • Press Shift+Tab to navigate to the block toolbar.
  • Use the right/left arrow keys to navigate to the 'More' button and press Enter to open the dropdown menu.
  • The first menu item is 'Highlight' and is already selected: just press Enter again.
  • A color picker popover opens.
  • Observe the popover is mispositioned and aligned to the left edge of the screen. Also the vertical position appears to be off.
  • Refresh the page.
  • This time, open the 'Highlight' popover by using the mouse.
  • Observe the popover is correctly positioned.
  • Activate a block-based theme e.g. Twenty Twenty-Three.
  • Repeat the steps above.
  • Observe the popover is always correctly positioned.

Screenshots, screen recording, code snippet

Mispositioned popover: Safari, classic theme, using the keyboard:

Screenshot 2023-02-23 at 15 13 26

Correct popover position: Safari, block-based theme, using the keyboard:

Screenshot 2023-02-23 at 15 16 05

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release [Package] Components /packages/components labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

1 participant