Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style randomizer: ensure colors are accessible #47296

Open
annezazu opened this issue Jan 19, 2023 · 1 comment
Open

Style randomizer: ensure colors are accessible #47296

annezazu opened this issue Jan 19, 2023 · 1 comment
Assignees
@vcanales
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

This has come up in the twentieth call for testing for the FSE Outreach Program:

However it produces some non-accessible colors for Primary, Secondary and Tertiary, at least over a black background.

While this was previously discussed some here #40988 (comment) I wanted to be sure there was a separated out issue for it.

What is your proposed solution?

Ensure some level of accessibility friendly calculations/randomizations. cc @vcanales
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jan 19, 2023
@vcanales vcanales self-assigned this Jan 20, 2023
@annezazu
Copy link
Contributor Author

Randomize colors had some button color contrast issues. Can we create rules that test for contrast that meets accessibility. I noticed this more quickly when in Storybook button view vs editing home page template.

This came up once more in the twentieth call for testing for the FSE Outreach Program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vcanales vcanales

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vcanales @annezazu