Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery Block: Difficult to "Add image" when existing image is selected #47200

Open
danielbachhuber opened this issue Jan 16, 2023 · 9 comments
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@danielbachhuber
Copy link
Member

It's difficult to add a new image to a Gallery Block.

The easiest thing to click is one of the existing images:

image

Once you have the image selected, you have to somehow know to click this icon all of the way to the left:

image

Only once you do that does the "Add" toolbar option become visible:

image

(Ignore the focused caption input, I think that's a bug)

As a user, I'd expect I could easily "Add image" whenever a Gallery Block or its children are selected.

@danielbachhuber danielbachhuber added the [Block] Gallery Affects the Gallery Block - used to display groups of images label Jan 16, 2023
@danielbachhuber
Copy link
Member Author

The List Block presents a similar conceptual challenge: when you have a List Item Block selected, you have to figure out how to navigate back up to the parent block in order to change the list type.

image

@aisajib
Copy link

aisajib commented Feb 2, 2023

Similar to above^, the List block presents another challenge when you have the "Ordered list" selected and want to choose a custom starting value (instead of 1).

CleanShot 2023-02-02 at 09 26 37

@annezazu annezazu added the [Type] Enhancement A suggestion for improvement. label Jul 12, 2023
@mtias mtias added the Needs Design Feedback Needs general design feedback. label Jul 12, 2023
@mikeicode
Copy link

A solution for the Gallery block could be to add the same upload feature from the Tiled Gallery block:

Screen Shot on 2023-07-12 at 16-22-50

@richtabor
Copy link
Member

As-is, you can't add blocks before/after blocks with locked inner blocks (buttons, gallery, list, etc). "Add before" and "Add after" are omitted entirely.

Perhaps we could add them back in, but a bit more specific for these use cases, like this:

add-image-before

The same could work for the buttons and list blocks, where they are only allowed one type of inner block. "Add button before" and "Add button after" etc.

@danielbachhuber
Copy link
Member Author

@richtabor I imagine it still exists because it wasn't ever converted to blocks, but I find this menu item of the Table Block to be pretty helpful (once I retrained my brain to look here instead of in the triple dot menu):

image

Another option to consider is showing a subset of the parent block's toolbar controls in a similar menu item on the child block.

@hanneslsm
Copy link

hanneslsm commented Aug 3, 2023

As a start, it'd be already beneficial if the Plus between the images on hover would be displayed, even if an image block within the gallery is selected (an not only the gallery block):
image
(By the way, I think that the animation is a bit slow and the Plus should appear a little bit quicker to make it more obvious, but this is another discussion)

@richtabor
Copy link
Member

I think that the animation is a bit slow

Agreed.

if the Plus between the images on hover would be displayed, even if an image block within the gallery is selected

In this case, I don't think we should show the inserter based on selecting blocks around it.

@hanneslsm
Copy link

In this case, I don't think we should show the inserter based on selecting blocks around it.

How do you mean this? The columns block also has this behavior and I think it's quite handy. Even when a block within a column block is selected, for example a Paragraph, the inserter appears. Only for the Gallery, you must select the parent Gallery block, but it does not work when a image within is selected.

@hanneslsm
Copy link

I think I just found a bug. Ignore my previous comments.
The inserter does appear in Galleries, even when an image is selected. However, it does not appear when the last image is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

7 participants