Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav block lacks context about menu currently being edited within the block #47020

Closed
getdave opened this issue Jan 10, 2023 · 3 comments · Fixed by #53469
Closed

Nav block lacks context about menu currently being edited within the block #47020

getdave opened this issue Jan 10, 2023 · 3 comments · Fixed by #53469
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Status] In Progress Tracking issues with work in progress

Comments

@getdave
Copy link
Contributor

getdave commented Jan 10, 2023

As reported in #46939 (comment) when entering the Nav block there is no context as to the menu were are editing. It should explain whether it's auto menu or one of the menus we've created. Also perhaps it should announce whether the menu is "saved" or in "draft"?

An accessible Name should be provided along the lines of Navigation Menu: %%NAV MENU NAME%% (also consider when the menu is an "auto" menu).

Related #47019

@getdave getdave added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Navigation Affects the Navigation Block [a11y] Labelling labels Jan 10, 2023
@scruffian
Copy link
Contributor

I'm not sure how we would do this. The block itself has an aria-label of "Block: Navigation", which is consistent with all other blocks. I'm hesitant to make an exception for this block.

In addition, if we create menus seamlessly (see Navigation: Create first menu seamlessly) then this information become redundant.

@annezazu
Copy link
Contributor

annezazu commented Aug 9, 2023

@alexstine this touches on a piece of feedback you had in your recent 6.3 video. Mind giving this PR a review when you have a chance? cc @joedolson and @afercia in case you all can help too!

@alexstine
Copy link
Contributor

Approved the change. Thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants