Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav off-canvas editor not offering the option to create a new page when it doesn't exist #46193

Closed
getdave opened this issue Nov 30, 2022 · 4 comments · Fixed by #52166
Closed
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Nov 30, 2022

In the Nav block when creating a new link, typing in the name of an entity which doesn't exist brings up a Create new draft page option in the Link UI search results. This allows you to create new draft pages directly from the Nav block.

That functionality is not present in the Nav offcanvas experiment.

Why?

It's intentional in the sense that I deliberately removed it.

Why?

Because including that functionality requires saveEntityRecord from @wordpress/core-data and we need to avoid coupling that package to block editor. I don't yet have a good way around this...

This is blocked by the above.


    it also looks like the off-canvas editor is not offering the option to create a new page when it doesn't exist. I don't know if that's intended or not. If not, then that's definitely something to follow up on.

Originally posted by @MaggieCabrera in #46189 (comment)

@getdave getdave self-assigned this Nov 30, 2022
@getdave getdave added the [Block] Navigation Affects the Navigation Block label Nov 30, 2022
@getdave getdave removed their assignment Nov 30, 2022
@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Status] Blocked Used to indicate that a current effort isn't able to move forward labels Mar 9, 2023
@annezazu
Copy link
Contributor

annezazu commented Apr 17, 2023

Ran into this while creating the next call for testing for the FSE Outreach Program. Would be great to see addressed and have some consistency here!

Add.draft.page.mov

@annezazu
Copy link
Contributor

Noting that this was brought up in the latest call for testing for the FSE Outreach Program as a point of inconsistency:

When I created a new page by way of creating a draft page. I found that a draft page creation option was missing if I tried to create it under the Menu sidebar https://s.id/1Nh2y. However, it showed up if I tried to add a non-existent page link via the Navigation block https://s.id/1NgZg.

@getdave
Copy link
Contributor Author

getdave commented Jun 30, 2023

I now know exactly how to fix this.

@getdave getdave self-assigned this Jun 30, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 30, 2023
@getdave
Copy link
Contributor Author

getdave commented Jun 30, 2023

This was a bug whereby the functionality was disabled for the Link UI component used in the Nav list view. It's fixed in #52166.

Noting that this required the work from the 6.3 cycle to allow this to happen.

@getdave getdave added the [Type] Bug An existing feature does not function as intended label Jun 30, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.
Projects
Development

Successfully merging a pull request may close this issue.

4 participants