Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page List: Lock icon in the inspector controls #46191

Closed
scruffian opened this issue Nov 30, 2022 · 9 comments · Fixed by #46578
Closed

Page List: Lock icon in the inspector controls #46191

scruffian opened this issue Nov 30, 2022 · 9 comments · Fixed by #46578
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Type] Enhancement A suggestion for improvement.

Comments

@scruffian
Copy link
Contributor

What problem does this address?

The Page List locking icon has been through a number of different iterations in the list view. Currently it doesn't display any lock icon at all:

Screenshot 2022-11-30 at 11 11 01

What is your proposed solution?

As outlined in #42257 we should consider using a sync icon to communicate the concept that these items are in a controlled state:
Screenshot 2022-11-30 at 11 12 14

@scruffian scruffian added [Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block labels Nov 30, 2022
@MaggieCabrera
Copy link
Contributor

Should we rename the Page list block to Auto-menu too? I think that name makes less sense when we use the block outside the navigation block, which has valid use cases.

@scruffian
Copy link
Contributor Author

We should also consider removing the edit button for the inner blocks.

@MaggieCabrera
Copy link
Contributor

We should also consider removing the edit button for the inner blocks.

We have done that already in #46163

@scruffian
Copy link
Contributor Author

scruffian commented Dec 9, 2022

That's what I thought, but they have come back:

Screenshot 2022-12-09 at 15 49 09

Edit: This was actually a bug in #46416

@scruffian
Copy link
Contributor Author

We updated the icon in #46438

@scruffian
Copy link
Contributor Author

We should consider using smaller lock icons for when a parent is locked:

screenshot-2022-12-07-at-10 18 03 copy

@draganescu
Copy link
Contributor

I can't figure out from the comments what is this issue, a bug or an enhancement?

@scruffian
Copy link
Contributor Author

Enhancement

@MaggieCabrera MaggieCabrera self-assigned this Dec 13, 2022
@MaggieCabrera MaggieCabrera added the [Type] Enhancement A suggestion for improvement. label Dec 13, 2022
@MaggieCabrera
Copy link
Contributor

Codepen for the solution with the icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants