Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkControl: Page Template links appear inside Link Control #46149

Closed
scruffian opened this issue Nov 29, 2022 · 1 comment
Closed

LinkControl: Page Template links appear inside Link Control #46149

scruffian opened this issue Nov 29, 2022 · 1 comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)

Comments

@scruffian
Copy link
Contributor

What problem does this address?

When creating a new link inside a template part, an additional "edit" icon is created, to edit the page template:

Steps to replicate:

  1. Open the site editor
  2. Edit a template part
  3. Add a paragraph block
  4. Add some text to the block
  5. Create a link with that text
  6. Deselect and reselect the linked text
  7. Notice that the Link Control UI loads and then reloads. On the reload, notice that there are two edit icons, one for the Page Template:

Screenshot 2022-11-29 at 10 51 39

I'm not sure what the correct solution is here - the page template editing is added via a slot fill here. Should this be using LinkControl for this purpose? Or should the Link UI not be using the LinkControl component?

@scruffian scruffian added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label Nov 29, 2022
@jordesign
Copy link
Contributor

I can no longer recreate this with the new Link UI (added prior to WP6.3 RC3 which I'm testing) so I'll close this as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)
Projects
None yet
Development

No branches or pull requests

2 participants