Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation Block] Experiment: Change focus when we edit a menu item to the correct tab #45951

Closed
MaggieCabrera opened this issue Nov 21, 2022 · 3 comments
Assignees
Labels
[Block] Navigation Affects the Navigation Block

Comments

@MaggieCabrera
Copy link
Contributor

Description

When we are editing a menu item, we want the focus to be on the Settings tab instead of the Appearances one, since we are expecting to edit content before styling.

Step-by-step reproduction instructions

Turn on the Gutenberg experiments Off canvas navigation editor and Block inspector tabs
Edit a link on the navigation block

Screenshots, screen recording, code snippet

Screen Capture on 2022-11-21 at 19-01-27

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talldan
Copy link
Contributor

talldan commented Dec 5, 2022

Random thoughts, and not something to act on: This seems to challenge the idea of appearance alway being the first tab for every user. Which makes me wonder whether there might be other options for the future.

e.g. a designer role where appearance is always first, and an editor role where settings is always first. Other alternatives could could be making this a preference or an editor mode (design mode, but then there wouldn't necessarily be a need for tabs). Or the editor could remember the last selected tab (would need an a11y check on this).

@scruffian
Copy link
Contributor

Also noting that the Navigation block has this List View button which opens the inspector controls. Ideally it would also focus the first tab.
Screenshot 2022-12-09 at 15 56 12

@scruffian
Copy link
Contributor

Now that Navigation List blocks don't have tabs I think this is no longer an issue.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
6 participants