Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Missing font-size declarations #42781

Closed
2 tasks done
mirka opened this issue Jul 28, 2022 · 1 comment
Closed
2 tasks done

Components: Missing font-size declarations #42781

mirka opened this issue Jul 28, 2022 · 1 comment
Assignees
Labels
[Package] Components /packages/components

Comments

@mirka
Copy link
Member

mirka commented Jul 28, 2022

What problem does this address?

#42747 uncovered that some components rely on a font-size: 13px being set in the surrounding CSS context. This is not a given, and we need that font-size to be explicitly set in each component for them to be self-sufficient.

What is your proposed solution?

This could've been fine if the component library were designed with dynamic sizing in mind, but in reality they are designed with fixed pixel values, and the majority of components do have an explicit font-size: 13px set within them. So let's maintain that consistency throughout the package.


Can be closed when the following are merged:

@mirka
Copy link
Member Author

mirka commented Aug 8, 2022

We may uncover some minor cases, but the known ones are all addressed now.

@mirka mirka closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components
Projects
None yet
Development

No branches or pull requests

1 participant