Site Editor Inserter(s): Prioritise Template Parts over Patterns, and indicate the difference between the two

[jameskoster]

The quick inserter currently surfaces patterns, both by default and when you search:

But it's not always clear whether the options (like in the screenshot above) are template parts or patterns, which can lead to folks mistakenly inserting a pattern where a template part would be preferable.

This issue can be partially fixed by #41397, but it might be best to establish some visual distinction to cover cases where patterns and template parts share a name. There are a couple ways to do this, one solution would be to simply list them separately:

This would be similar to what you find in the current implementation of the template part replacement modal:

Another option would be to list them together but use the template part icon to distinguish between patterns and things like headers / footers. Rough example:

[DaisyOlsen]

I can see merit in both the icon indicators and the separate sections. I'd lean toward separation because template parts and patterns are functionally different so a more obvious separation might be helpful. I also think that, in most cases, parts would be used more frequently in the site editor than patterns.

[carolinan]

I would prefer the icon because I feel a bit overwhelmed by the size of the inserter in the example.

[jameskoster]

I don't have a strong opinion, but do lean slightly towards the separation approach purely because it is consistent with other UIs that present the same content. We can explore how we might improve the experience holistically as a dedicated effort, rather than having several of different versions of essentially the same thing across the editor.

[mtias]

Where did we end up with this?

[jameskoster]

Seems we're looking for consensus on how to present everything. These are the options we have atm:

Now that I think of it, another option would be: Clicking the root-level inserter engages the zoomed-out view with the main Inserter panel open. The separation of template parts / patterns is handled therein.

[jordesign]

I'm not seeing the pattern/part preview within the quick inserter any more - is this issue still relevant @jameskoster

[jameskoster]

It's still there, but only at the document root by the looks of things:

Seems we're looking for consensus on how to present everything.

The Pattern management view didn't exist when we last looked at this, and I think it sets a precedent that can inform the direction here:

It uses the icon approach above to communicate the synced nature of a given pattern. This is probably adequate on its own (no need to re-order). I'll update the OP.

Edit: It seems that when the quick inserter is set to display patterns it will only return unsynced ones (IE no template parts), even when you search. So this issue doesn't really exist any more, but the quick inserter should be updated to include synced patterns. I'll open a new issue for that one.