Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color popovers: inconsistent styling #41787

Closed
jameskoster opened this issue Jun 17, 2022 · 1 comment · Fixed by #43570
Closed

Color popovers: inconsistent styling #41787

jameskoster opened this issue Jun 17, 2022 · 1 comment · Fixed by #43570
Assignees
Labels
[Feature] Colors Color management [Package] Components /packages/components

Comments

@jameskoster
Copy link
Contributor

Here are the color palette, and custom color picker popovers:

Screenshot 2022-06-17 at 12 50 49

As you can see, they both have different shadow styles, and the custom color popover has no border while the color palette one does. It would be nice to align the appearance:

Screenshot 2022-06-17 at 12 54 51

The padding is slightly different too, so we might consider correcting that as well.

@mirka
Copy link
Member

mirka commented Aug 5, 2022

This should be pretty simple.

  1. Wrap it with <DropdownContentWrapper paddingSize="none">.

  2. Remove these style overrides:

    overflow: visible;
    box-shadow: 0 4px 4px rgba(0, 0, 0, 0.05);
    border: none;
    outline: none;
    border-radius: $radius-block-ui;
    padding: 0;

@mirka mirka self-assigned this Aug 24, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 24, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management [Package] Components /packages/components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants