Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Improve development env on Windows OS #39388

Closed
t-hamano opened this issue Mar 11, 2022 · 7 comments
Closed

Tracking: Improve development env on Windows OS #39388

t-hamano opened this issue Mar 11, 2022 · 7 comments
Assignees
Labels
[Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Mar 11, 2022

Overview

I checked all scripts in package.json, and found that some scripts are not work correctly on Windows OS.

This tracking issue is targeted to fix npm scripts to allow for smooth development on Windows OS.

I would like to find out the detailed cause and send PR in several chunks.

I would appreciate your help in testing, both on Windows / Mac.

Scripts that do not work on Windows OS

As far as I have tested, the following scripts did not work.

I also excluded scripts that may work correctly as a result of fix the following scripts.
( e.g. dev, which depends on dev:packages )

status script name Error Logs / Error Details PR for Fix
build:plugin-zip '.' is not recognized as an internal or external command, operable program or batch file. #39739
changelog '.' is not recognized as an internal or external command, operable program or batch file. #39739
test-unit:date '.' is not recognized as an internal or external command, operable program or batch file. #39739
test:create-block '.' is not recognized as an internal or external command, operable program or batch file. #39739
check-local-changes 'xargs' is not recognized as an internal or external command, operable program or batch file. #41074
dev:packages File modification not detected #40566
lint-css / lint-css:fix Error: No files matching the pattern "'**/*.scss'" were found. #39447
test-unit Some tests fail with many errors #41070
prelint-php /docker-entrypoint.sh: exec: line 24: 'install: not found #39447
test-unit-php sudo: 'phpunit: command not found #39447
test-unit-php-multisite × Command failed with exit code 2 #39447

What is the cause?

I think that one of the following is the cause.

@t-hamano t-hamano added the [Type] Build Tooling Issues or PRs related to build tooling label Mar 11, 2022
@gziolo gziolo added the [Type] Bug An existing feature does not function as intended label Mar 14, 2022
@gziolo
Copy link
Member

gziolo commented Mar 14, 2022

This is a great initiative. Thank you for opening this issue.

@gziolo
Copy link
Member

gziolo commented Mar 24, 2022

I landed the first batch of changes. I tested them from the trunk branch on macOS to ensure it still works there :)

@t-hamano
Copy link
Contributor Author

Thanks for confirming ! I will continue to work on another task 👍

@gziolo
Copy link
Member

gziolo commented Mar 25, 2022

We could also look at standardizing names for scripts executed with npm run while we test all of them. See related issue: #19949.

@gziolo
Copy link
Member

gziolo commented Apr 20, 2022

I landed #39739. There are 3 commands left from the list 🎉

@t-hamano t-hamano self-assigned this May 17, 2022
@t-hamano t-hamano added the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label May 23, 2022
@gziolo
Copy link
Member

gziolo commented May 27, 2022

I have just landed changes for check-local-changes. Does it mean we have only test-unit left? 😄

@t-hamano
Copy link
Contributor Author

Oh, I must have put in the wrong PR number.
test-unit is already done with #41070.

So all issues are now resolved.
If I find any new OS-related issues in the future, I would like to submit a new issue.

Thank you for your cooperation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

2 participants