Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting template or template part causes screen flash in Site Editor #37926

Closed
annezazu opened this issue Jan 12, 2022 · 2 comments · Fixed by #48449
Closed

Deleting template or template part causes screen flash in Site Editor #37926

annezazu opened this issue Jan 12, 2022 · 2 comments · Fixed by #48449
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

When deleting a template or template part, the screen flashes upon deletion. It's a bit jarring of an experience!

Step-by-step reproduction instructions

  1. Create a new template from the Site Editor.
  2. Head to the template list and delete it.
  3. See the flash on the screen.

Screenshots, screen recording, code snippet

Screen.Recording.2022-01-12.at.12.04.21.PM.mov

Environment info

  • WordPress 5.9 RC2
  • No GB
  • TT2
  • Chrome
  • MacOS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Block] Template Part Affects the Template Parts Block labels Jan 12, 2022
@annezazu
Copy link
Contributor Author

annezazu commented Feb 7, 2022

This still happens in 5.9.

@youknowriad
Copy link
Contributor

This happens probably because the request is retriggered. It's easy enough to keep the list visible but I guess we should show some feedback that the request is in progress. Might need some design here.

@youknowriad youknowriad added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Feb 24, 2023
@annziel annziel mentioned this issue Feb 25, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix screen flash when deleting templates in templates list annziel/gutenberg
2 participants
@youknowriad @annezazu