Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Styles UI: Add tooltip on hover #37039

Open
shaunandrews opened this issue Dec 1, 2021 · 2 comments
Open

Block Styles UI: Add tooltip on hover #37039

shaunandrews opened this issue Dec 1, 2021 · 2 comments
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes [Type] Enhancement A suggestion for improvement.

Comments

@shaunandrews
Copy link
Contributor

With the new UI for block styles in the inspector sidebar, longer style names have been truncated. The full style name does appear in the preview flyout, but it might be helpful to also show a tooltip near the button with the full style name:

image

@ramonjd
Copy link
Member

ramonjd commented Dec 1, 2021

Just to loop back as to when and why we added the ellipsis:

#34522 (comment)

Here I'm wrapping each button in a <Tooltip />

Kapture 2021-12-02 at 10 00 59

Kapture 2021-12-02 at 10 01 51

We could do it for all or for Buttons whose label lengths are > 12, which is the point at which the text control truncates.

@shaunandrews
Copy link
Contributor Author

I'd expect the tooltip to appear (below the button) regardless of the length of the label; Otherwise it feels strangely inconsistent.

My only bit of feedback here is around the position of the tooltip; It appears to "touch" the button and can end up looking a little awkward. I don't think its really tied to this issue, so I created a new one in #37076.

@annezazu annezazu added [Feature] Theme Style Variations Related to style variations provided by block themes [Type] Enhancement A suggestion for improvement. labels Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants