Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "none" as an alignment option and use contextual text to clarify settings. #34597

Closed
Tracked by #29506
mtias opened this issue Sep 6, 2021 · 2 comments · Fixed by #34710
Closed
Tracked by #29506

Show "none" as an alignment option and use contextual text to clarify settings. #34597

mtias opened this issue Sep 6, 2021 · 2 comments · Fixed by #34710
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress

Comments

@mtias
Copy link
Member

mtias commented Sep 6, 2021

Updates the design of the alignment dropdown to include "none" as an option (it's the same as unsetting). The center icon has been updated, and the previous icon for centering has been repurposed for indicating "None". There's help text for "None" and "Wide", to show the values for the content and wide area layout values.

Group 259

For themes that do not support wide or fullwide alignments we render some contextual text to clarify the missing buttons:

Group 260
@mtias mtias mentioned this issue Sep 6, 2021
12 tasks
@mtias mtias added [Feature] Blocks Overall functionality of blocks [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Sep 6, 2021
@richtabor
Copy link
Member

May be overthought, but perhaps there's a way to dismiss (localStorage) the "Your theme doesn't support.." notice so that it brings awareness, but doesn't convey the theme being sub-par every time you see this?

@mtias
Copy link
Member Author

mtias commented Sep 7, 2021

Perhaps we can reword it so that it's less of a "doesn't support" and more of a choice? We could use the same wording as on containers that don't have wide / full for various reasons, like columns or there being a sidebar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants