Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Row Block #32522

Closed
melchoyce opened this issue Jun 8, 2021 · 5 comments
Closed

Add a Row Block #32522

melchoyce opened this issue Jun 8, 2021 · 5 comments
Labels
New Block Suggestion for a new block

Comments

@melchoyce
Copy link
Contributor

What problem does this address?

The Columns block allows you to do interesting layouts like this, where there are columns of text with different alignments:

image

But there isn't an equivalent way to handle this vertically:

image

The best approximation is to add a spacer between the top and bottom text, which is subpar for a number of reasons — the spacer maxes out at 500px tall, it looks bad on mobile, there isn't a way to make the spacer take up a percentage of height, etc.

What is your proposed solution?

Add a row block that acts the same as columns, but vertically instead of horizontally.

@kjellr
Copy link
Contributor

kjellr commented Jul 13, 2021

I think this is more or less a duplicate of #24473. @melchoyce can you confirm?

@melchoyce
Copy link
Contributor Author

Honestly can't tell, that seems more specifically about flexbox integration and horizontal grouping?

@kjellr
Copy link
Contributor

kjellr commented Jul 13, 2021

Hmm yeah maybe it's a little different. The end result is the same though: blocks arranged horizontally in columns.

@paaljoachim
Copy link
Contributor

@youknowriad merged this PR: #34535

@annezazu
Copy link
Contributor

annezazu commented May 24, 2022

I think this can be closed out with the addition of the Row block in 6.0. If folks disagree, happy to reopen <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Block Suggestion for a new block
Projects
None yet
Development

No branches or pull requests

4 participants