Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input with save button #30215

Closed
grzim opened this issue Mar 24, 2021 · 5 comments
Closed

Add input with save button #30215

grzim opened this issue Mar 24, 2021 · 5 comments
Assignees
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.

Comments

@grzim
Copy link
Contributor

grzim commented Mar 24, 2021

What problem does this address?

In Navigation Editor, when a menu name is changed, a user needs to hit the save button in order to apply the change. This is not obvious action and is not UX-friendly.

What is your proposed solution?

As proposed by @shaunandrews we can add a component with a save button inside an input. This will make a saving action more straightforward.
image

@grzim grzim added [Feature] UI Components Impacts or related to the UI component system [Package] Edit Navigation labels Mar 24, 2021
@grzim grzim self-assigned this Mar 24, 2021
@paaljoachim
Copy link
Contributor

What about adding in a button that says save?

@grzim
Copy link
Contributor Author

grzim commented Mar 25, 2021

@paaljoachim currently we have a save button that saves configuration from the navbar.
However, as mentioned in comment, it is not obvious for a user, they need to click on save therefore it would be better to introduce this component.

But on the other hand, we would end up in the situation, when only menu rename has its own button to save, whereas the rest of the config in the same area is saved all with one button.
This could lead to confusion as well.

@shaunandrews I will be grateful if you can share your thoughts on this.

@talldan
Copy link
Contributor

talldan commented Mar 26, 2021

I noticed there's one just like this in the LinkControl component when editing a link:
Screenshot 2021-03-26 at 9 10 20 am

But it doesn't look particularly easy to extract this into a general purpose component. There's quite a bit going on.

@shaunandrews
Copy link
Contributor

I think if we improve our handling of unsaved changes as outlined in #30322 we won't need to have a discrete save button for the menu name.

@grzim
Copy link
Contributor Author

grzim commented Mar 30, 2021

Thanks for your feedback @shaunandrews

@grzim grzim closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants