Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button Block: Add e2e test for gradients support #29992

Closed
ockham opened this issue Mar 18, 2021 · 1 comment · Fixed by #46452
Closed

Button Block: Add e2e test for gradients support #29992

ockham opened this issue Mar 18, 2021 · 1 comment · Fixed by #46452
Assignees
@t-hamano
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Package] E2E Tests /packages/e2e-tests [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@ockham
Copy link
Contributor

ockham commented Mar 18, 2021

Gutenberg 10.2.0 had a regression with regard to the Button block that lost its gradients support (see #29980) . Let's add some e2e test coverage for that.
@ockham ockham added [Type] Task Issues or PRs that have been broken down into an individual action to take [Block] Cover Affects the Cover Block - used to display content laid over a background image [Package] E2E Tests /packages/e2e-tests labels Mar 18, 2021
@ockham ockham changed the title Cover Block: Add e2e test for gradients support Button Block: Add e2e test for gradients support Mar 18, 2021
@ockham ockham mentioned this issue Mar 18, 2021
Merged
@t-hamano
Copy link
Contributor

I would like to work on this issue.
The e2e test for custom colors in the heading block has been added in #37382 and I plan to use this as a reference 🙂

@t-hamano t-hamano self-assigned this Dec 10, 2022
@t-hamano t-hamano mentioned this issue Dec 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-hamano t-hamano

Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Package] E2E Tests /packages/e2e-tests [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

E2E tests: Add width and color test to button block WordPress/gutenberg
2 participants
@ockham @t-hamano