Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery block refactor: Image block cropping tool does not work well in gallery context #29957

Open
glendaviesnz opened this issue Mar 18, 2021 · 3 comments
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended

Comments

@glendaviesnz
Copy link
Contributor

When running the Gallery Refactor PR using the crop tool on an individual image is slightly confusing as it doesn't work so well with images being forced to specific sized with the Gallery Crop images option toggled on. For instance with some image sizes a small square crop size is indicated, but when applied image zooms in at same shape and size as previous:

crop2

Also, the crop option interacts badly with the image caption with Crop images is toggled off:

crop1

@glendaviesnz glendaviesnz added [Type] Bug An existing feature does not function as intended [Block] Gallery Affects the Gallery Block - used to display groups of images labels Mar 18, 2021
@glendaviesnz
Copy link
Contributor Author

This is going to take a reasonable amount of UX work to figure out how to best handle this, and it doesn't seem to be a critical bug so deferring until after the first release of the refactored gallery block.

@annezazu
Copy link
Contributor

annezazu commented Feb 7, 2022

This came up as part of the latest FSE Outreach Program's All Things Media exploration:

Cropping I expect what I am used to from photo programs to where I can manually adjust the grid lines. Instead one has to select aspect ratio icon.

You can see a video talking through the brief experience here. Separately, there was more feedback around when one is just trying to rotate an image in a gallery:

I have tried to rotate an image of 180° in a gallery. I have read that also others have had problems with this feature, in my particular case I think it’s due to a “pre-selection” of a crop area after rotating the image of 180°, while I’m expecting that no cropping is pre-selected, I want only to rotate 🙂
My steps:
-Fresh local WP installation
-Twenty twenty-two theme
-Created a new article
-Created a new gallery of 13 images
-Selected an image
-Clicked Crop (to a newbie I think it’s not very immediate to know that Rotate in the UI is under Crop)
-Clicked rotate twice –> then you have the image rotated by 180° BUT there is a pre-selected cropped area instead to leave the original dimension

@mrfoxtalbot
Copy link

mrfoxtalbot commented Mar 29, 2022

I have noticed something similar. If the gallery has more than one column, the offered cropping area does not use up all the available space, which is confusing and ineffective.

Screen.Capture.on.2022-03-29.at.15-49-01.mp4

This problem only seems to happen when the gallery if first added, and before the post is saved. Once the post is saved, it works more consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants