Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSE] Add a notice after Updating Design to confirm changes #29846

Closed
annezazu opened this issue Mar 12, 2021 · 3 comments
Closed

[FSE] Add a notice after Updating Design to confirm changes #29846

annezazu opened this issue Mar 12, 2021 · 3 comments
Labels
[Feature] Saving Related to saving functionality General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

Currently, saving in FSE is a two step process where one first clicks "Update Design" before being presented with options to select which changes to save. After confirming what you want to save though, there's no additional notice or indication in the UI that changes have been captured beyond the "Update Design" button greying out. Here's the experience:

FSE.save.mov

This came up as part of the third call for testing for the FSE Outreach Program:

Once the design is saved, there is no confirmation but the button is no longer operable. The interface could communicate this better.

What is your proposed solution?

I think we should re-use the messaging for saving a post in the core editor:

save.post.process.mov

This could include an additional link to view the front end of the site but that likely will be too tricky considering multi-entity saving complexities. Here's a pretend mockup with a dismissible notice:

Screen Shot 2021-03-12 at 4 03 19 PM

The verbiage is purposefully vague as I'm not sure if we could get specific enough to go through each specific change (template part, template, post, global styles, etc).

This issue overall somewhat relates to this open issue around the saving flow in general: #29577

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Feature] Saving Related to saving functionality labels Mar 12, 2021
@javierarce
Copy link
Contributor

javierarce commented Mar 29, 2021

+1 to adding a snackbar.

If I'm not mistaken, looking at the code of the save function we do have access to the kind, name, and key information of the saved entities, so I think we could be pretty specific with the message we show.

I think we could use these rules:

  • If the user saves just a specific element, we inform about it: 'Header updated' or 'Page updated'.
  • If the user saves several elements of the same type (e.g.: 'Header' and 'Footer' areas), we refer to that instead: 'Templates updated'.
  • If the user saves several elements of different types (e.g.: Page, Header, and Footer), we show a generic message: 'Changes saved' or 'Design saved'.

@annezazu
Copy link
Contributor Author

I dig that approach!

@annezazu
Copy link
Contributor Author

annezazu commented Mar 5, 2022

Closing this out! It now send a notice of "Site Updated" after changes our made :)

@annezazu annezazu closed this as completed Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Saving Related to saving functionality General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants