Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker not showing Cancel and Apply buttons #25646

Closed
guarani opened this issue Sep 25, 2020 · 2 comments
Closed

Color picker not showing Cancel and Apply buttons #25646

guarani opened this issue Sep 25, 2020 · 2 comments
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Comments

@guarani
Copy link
Contributor

guarani commented Sep 25, 2020

Describe the bug

On the color picker bottom sheet that's displayed when choosing a custom Button block color, the "Cancel" and "Apply" buttons can sometimes disappear for no apparent reason.

While the following steps describe the scenario for Button Text Color, the same might apply for Gradient Color. Also, this likely affects the Cover block, not just the Button block.

To reproduce

  1. Open the Gutenberg demo app for iOS
  2. Add a Button block
  3. Go to Block Settings
  4. Tap Text Color
  5. Select Custom
  6. Choose a color and tap Apply
  7. Tap Custom again and notice the bottom sheet doesn't have a "Cancel" or "Apply" button

Expected behavior

The "Cancel" and "Apply" buttons should be available the second time the user enters the color picker, just as they were available the first time.

Screenshots

(The screen recording below doesn't show the default colors, but that's due to a different issue wordpress-mobile/gutenberg-mobile#2649 which is now resolved.)

Screen recording showing color palette missing Apply and Cancel buttons

Smartphone (please complete the following information):

  • Device: iPhone 11
  • OS: iOS 14
  • Demo App Version master branch
@guarani guarani added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Sep 25, 2020
@chipsnyder
Copy link
Contributor

@guarani (Not Urgent) I'm pretty sure this issue has now been resolved (Tested in WP iOS 16.7) can you confirm if you're able to reproduce it or not?

@guarani
Copy link
Contributor Author

guarani commented Feb 22, 2021

@guarani (Not Urgent) I'm pretty sure this issue has now been resolved (Tested in WP iOS 16.7) can you confirm if you're able to reproduce it or not?

Yes, this looks to have been fixed (checked WPiOS 16.7 beta). Closing this now 👍

@guarani guarani closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

No branches or pull requests

2 participants